Bug 139114 - Update multimedia/vlc to 1.0.2
Summary: Update multimedia/vlc to 1.0.2
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Thierry Thomas
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-09-24 15:10 UTC by Christopher Key
Modified: 2009-11-02 23:00 UTC (History)
0 users

See Also:


Attachments
multimedia-vlc-1.0.2.patch (2.43 KB, patch)
2009-09-24 15:10 UTC, Christopher Key
no flags Details | Diff
multimedia-vlc-1.0.2-without-x11.patch (8.05 KB, patch)
2009-10-08 23:11 UTC, Christopher Key
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Christopher Key 2009-09-24 15:10:01 UTC
	VLC 1.0.2 has been released, and fixes a security issue, http://www.videolan.org/security/sa0901.html.

Fix: The attached patch applies cleanly, but hasn't been directly tested as no X11 machine is available.  It does however compile successfully when combined with the changes mentioned in PR ports/135018.
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2009-09-24 15:10:09 UTC
Maintainer of multimedia/vlc,

Please note that PR ports/139114 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/139114

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2009-09-24 15:10:11 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 3 Doug Barton freebsd_committer freebsd_triage 2009-09-28 01:19:12 UTC
Responsible Changed
From-To: freebsd-ports-bugs->pgollucci


This update compiles and runs fine for me, can you incorporate it into 
your work on 135018?  

FYI, while this update does compile and run, I still have the bug 
where vlc "captures" the keyboard whenever I start it (with the GUI), 
and doesn't allow input from the keyboard into any program, including 
itself.  This bug has been present since version 1.0. 

Also, if memory serves this is the second update that the current 
maintainer has missed, in addition to not seeming to have time to 
address this keyboard issue.  Perhaps you might want to have a 
conversation with him about his availability for maintaining the port. 

Doug
Comment 4 Christopher Key 2009-10-08 23:11:34 UTC
Updated version of the patch encorporating the changes from ports/135018.

Looking at
http://git.videolan.org/?p=vlc.git;a=blob_plain;f=NEWS;hb=HEAD, it
appears that there have been some changes to the X11 system, so it might
be worth trying a recent trunk version to see if it fixes the keyboard
capture issues.
Comment 5 Joseph S. Atkinson 2009-10-11 14:32:55 UTC
Approved.

Tested this locally, and it built fine, worked WITHOUT_X11 as well, but 
would like to see this build configuration run on a tinderbox if possible.
Comment 6 dfilter service freebsd_committer freebsd_triage 2009-11-02 22:51:41 UTC
thierry     2009-11-02 22:51:27 UTC

  FreeBSD ports repository

  Modified files:
    multimedia/vlc       Makefile Makefile.inc distinfo 
    multimedia/vlc/files patch-v4l 
  Added files:
    multimedia/vlc/files patch-configure-dvbpsi 
  Removed files:
    multimedia/vlc/files patch-modules__access__file.c 
  Log:
  Upgrade to 1.0.2 and fix a security issue: see
  <http://www.videolan.org/security/sa0901.html>.
  
  Also include fixes from PR ports/135018 to fix build when WITHOUT_X11 is
  defined.
  
  PR:             ports/139114 (1) ports/135018 (2)
  Submitted by:   Christopher Key <cjk32 (at) cam.ac.uk> (1) Nick Triantos <nick-freebsd (at) triantos.com> (2)
  Approved by:    Joseph S. Atkinson <jsa.bsd (at) gmail.com> (maintainer)
  Security:       VideoLAN-SA-0901 (CVE Pending)
  
  Revision  Changes    Path
  1.197     +18 -14    ports/multimedia/vlc/Makefile
  1.24      +6 -2      ports/multimedia/vlc/Makefile.inc
  1.32      +3 -3      ports/multimedia/vlc/distinfo
  1.1       +20 -0     ports/multimedia/vlc/files/patch-configure-dvbpsi (new)
  1.2       +0 -10     ports/multimedia/vlc/files/patch-modules__access__file.c (dead)
  1.4       +0 -11     ports/multimedia/vlc/files/patch-v4l
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 7 Thierry Thomas freebsd_committer freebsd_triage 2009-11-02 22:51:46 UTC
State Changed
From-To: feedback->closed


Approved by maintainer and committed, thanks! 



Comment 8 Thierry Thomas freebsd_committer freebsd_triage 2009-11-02 22:51:46 UTC
Responsible Changed
From-To: pgollucci->thierry


Committed it on pgollucci's behalf, due to ApacheCon US 2009.