Bug 139490 - [patch] x11-wm/tvtwm fixes for users of firefox3, gimp and other apps
Summary: [patch] x11-wm/tvtwm fixes for users of firefox3, gimp and other apps
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-10-10 20:10 UTC by Kurt Jaeger
Modified: 2009-10-22 12:20 UTC (History)
0 users

See Also:


Attachments
file.shar (16.85 KB, text/plain)
2009-10-10 20:10 UTC, Kurt Jaeger
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Kurt Jaeger 2009-10-10 20:10:00 UTC
	tvtwm has several problems which manifest themselves when using
	modern applications like firefox3 or gimp or many others.

	1) If you use the 'print' menue in firefox3 and 'cancel' after
	the firefox3 menue comes up, twm will restart, which de-iconifies
	your icons and reshuffles window locations. This is very annoying
	and makes tvtwm unusable if many windows/icons are in use.
	Similar effects come in many modern applications which trigger
	file selection popups.

	2) If you stop and restart tvtwm, all windows sometimes move
	a little bit to the right and a little bit to the bottom.
	This is due to incomplete support for window borders calculations
	during restart.

	3) If you use the virtual screen feature of tvtwm and
	select eg. virtual screen 5, then stop tvtwm and restart it,
	all windows in virtual screens 1-4 become unaccessible because
	the window location is wrongly calculated.

	4) If you start a second firefox3 profile in a different
	virtual screen n than virtual screen 1, the window offsets during
	the iconify operation will be miscalculated, which causes
	firefox3 windows to disappear after one iconify/deiconify/iconify
	cycle. They will not really disappear, but their x coordinates
	are miscalculated and the window will reappear in virtual
	screen n*2.

	All those bugs make tvtwm unusable with modern applications.
	The tvtwm port attached contains the patches to fix this.

How-To-Repeat: 	1) how to repeat
	- start some xterm, iconify it
	- start firefox3
	- press ctrl-p in firefox3 and select 'cancel'
	the iconified xterm will de-iconify and loose its coordinates.

	2) how to repeat
	- startx and start tvtwm
	- start some xterm
	- stop tvtwm and restart it
	the window will move for the values of 'border and title' pixels
	to the right and bottom.

	3) how to repeat
	- start tvtwm with virtual screens, with
	  VirtualDesktop  "eval(WIDTH*7)`x'eval(HEIGHT)"
	  "F2"    = m     : all   : f.scroll "+1+1"
	  "F5"    = m     : all   : f.scroll "+4+1"
          in the .twmrc
	- start some xterm in virtual screen 1
	- select key F5 to move to the 5th virtual screen
	- start some other xterm in virtual screen 5
	- stop tvtwm and restart
	virtual screen 5 will become virtual screen 1 and
	the screens below virtual screen 5 will become unreachable.

	4) how to repeat
	- start tvtwm like in 3)
	- start a firefox3 browser in virtual screen 2
	- iconify, deiconify and iconify again
	the icon will appear in some other virtual screen (3, 4, 5?)
	or will disappear because it will land in negative y coordinates
Comment 1 dfilter service freebsd_committer freebsd_triage 2009-10-22 12:19:35 UTC
krion       2009-10-22 11:19:26 UTC

  FreeBSD ports repository

  Modified files:
    x11-wm/tvtwm         Makefile 
    x11-wm/tvtwm/files   patch-parse.c 
  Added files:
    x11-wm/tvtwm/files   patch-icons.c patch-menus.c patch-parse.h 
                         patch-twm.c 
  Log:
  - Fix windows behaviour after restart
  - Fix virtual screen behaviour after restart
  - Fix printing issue with Firefox3 which caused tvtwm to restart
  
  PR:             ports/139490
  Submitted by:   Kurt Jaeger <pi@opsec.eu>
  
  Revision  Changes    Path
  1.29      +0 -0      ports/x11-wm/tvtwm/Makefile
  1.1       +31 -0     ports/x11-wm/tvtwm/files/patch-icons.c (new)
  1.1       +88 -0     ports/x11-wm/tvtwm/files/patch-menus.c (new)
  1.2       +12 -4     ports/x11-wm/tvtwm/files/patch-parse.c
  1.1       +10 -0     ports/x11-wm/tvtwm/files/patch-parse.h (new)
  1.1       +229 -0    ports/x11-wm/tvtwm/files/patch-twm.c (new)
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 2 Kirill Ponomarev freebsd_committer freebsd_triage 2009-10-22 12:19:44 UTC
State Changed
From-To: open->closed

Committed. Thanks!