Fix: Patch attached with submission follows:
Responsible Changed From-To: freebsd-bugs->freebsd-ports-bugs Ports PR
Class Changed From-To: update->change-request Fix category (new ports should be change-requests) (via the GNATS Auto Assign Tool)
Responsible Changed From-To: freebsd-ports-bugs->amdmi3 I'll take it.
* Dmitry Yashin (yashin.dm@gmail.com) wrote: > >Synopsis: New port: net-p2p/uhub uHub is a high performance peer-to-peer hub for the ADC network etc/* files are not listed in the plist. These also require special handling: http://www.freebsd.org/doc/en/books/porters-handbook/plist-config.html Also, the port doesn't respect PREFIX and LOCALBASE, makefile patch should be like this: --- patch-GNUmakefile begins here --- --- GNUmakefile.orig 2009-03-24 02:21:38.000000000 +0300 +++ GNUmakefile 2009-10-19 21:02:02.000000000 +0400 @@ -31,10 +31,10 @@ BIN_EXT ?= .exe else DESTDIR ?= / -UHUB_CONF_DIR ?= $(DESTDIR)/etc/uhub -UHUB_PREFIX ?= $(DESTDIR)/usr/local -CFLAGS += -I/usr/local/include -LDFLAGS += -L/usr/local/lib +UHUB_PREFIX ?= $(PREFIX) +UHUB_CONF_DIR ?= $(UHUB_PREFIX)/etc/uhub +CFLAGS += -I${LOCALBASE}/include +LDFLAGS += -L$(LOCALBASE)/lib BIN_EXT ?= endif --- patch-GNUmakefile ends here --- another place is configuration files, I suggest you to use @{REINPLACE_CMD} -e 's|/etc/uhub|${PREFIX}&|' instead of patching config file. Finally, you shouldn't redefine uhub_start/stop targets if you do basically the same thing that is done by rc.subr by default. SIGKILL is very suspicious too - if the software doesn't handle sinals correctly, it should be patched in the code. -- Dmitry Marakasov . 55B5 0596 FF1E 8D84 5F56 9510 D35A 80DD F9D2 F77D amdmi3@amdmi3.ru ..: jabber: amdmi3@jabber.ru http://www.amdmi3.ru
State Changed From-To: open->feedback Awaiting submitters feedback
amdmi3 2009-11-11 16:43:59 UTC FreeBSD ports repository Modified files: net-p2p Makefile Added files: net-p2p/uhub Makefile distinfo pkg-descr pkg-plist net-p2p/uhub/files patch-GNUmakefile patch-main.c_add_pid uhub.sh.in Log: uHub is a high performance peer-to-peer hub for the ADC network. Its low memory footprint allows it to handle several thousand users on high-end servers, or a small private hub on embedded hardware. WWW: http://www.extatic.org/uhub/ PR: 139670 Submitted by: Dmitry Yashin <yashin.dm@gmail.com> Revision Changes Path 1.79 +1 -0 ports/net-p2p/Makefile 1.1 +37 -0 ports/net-p2p/uhub/Makefile (new) 1.1 +3 -0 ports/net-p2p/uhub/distinfo (new) 1.1 +35 -0 ports/net-p2p/uhub/files/patch-GNUmakefile (new) 1.1 +91 -0 ports/net-p2p/uhub/files/patch-main.c_add_pid (new) 1.1 +55 -0 ports/net-p2p/uhub/files/uhub.sh.in (new) 1.1 +5 -0 ports/net-p2p/uhub/pkg-descr (new) 1.1 +11 -0 ports/net-p2p/uhub/pkg-plist (new) _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
State Changed From-To: feedback->open Updated patch received
State Changed From-To: open->closed New port added. Thanks!