How-To-Repeat: 1. $ stty erase '^H' (to be sure) 2. $ tmux 3. $ stty erase '^H' 4. try to erase /-search string in less(1) using backspace
Responsible Changed From-To: freebsd-ports-bugs->wen Over to maintainer (via the GNATS Auto Assign Tool)
Hi, Thank your patch. Does this patch only for FreeBSD or could be used for any OS ? wen
wen heping <wenheping@gmail.com> writes: > Hi, > =C2=A0 > =C2=A0 Thank your patch. > =C2=A0=C2=A0Does this patch only for FreeBSD or could be used for any OS ? It depends on the bug this patch fixes. However, I'm not sure it'll be accepted upstream because of reaction to bug#2856672 on SF.net. http://sourceforge.net/tracker/?func=3Ddetail&aid=3D2856672&group_id=3D2003= 78&atid=3D973262 > =C2=A0 > wen
I've updated diff. The bug is that Backspace unconditionally produces \177 even when VERASE uses smth else. This breaks ncurses apps like vi(1), less(1). It may affect non-FreeBSD systems but I haven't tested. --- erase.diff begins here --- Index: sysutils/tmux/files/patch-tty-keys.c =================================================================== RCS file: sysutils/tmux/files/patch-tty-keys.c diff -N sysutils/tmux/files/patch-tty-keys.c --- /dev/null 1 Jan 1970 00:00:00 -0000 +++ sysutils/tmux/files/patch-tty-keys.c 3 Jun 2010 16:58:23 -0000 @@ -0,0 +1,11 @@ +--- tty-keys.c~ ++++ tty-keys.c +@@ -456,8 +456,6 @@ tty_keys_next(struct tty *tty) + * used. termios should have a better idea. + */ + bspace = tty->tio.c_cc[VERASE]; +- if (bspace != _POSIX_VDISABLE && key == bspace) +- key = KEYC_BSPACE; + goto handle_key; + } + --- erase.diff ends here ---
wen 2010-06-04 01:26:22 UTC FreeBSD ports repository Modified files: sysutils/tmux Makefile Added files: sysutils/tmux/files patch-tty-keys.c Log: - Fix the bug that tmux don't assume \177 as backspace char PR: ports/140339 Submitted by: Anonymous <swell.k@gmail.com> Revision Changes Path 1.16 +1 -1 ports/sysutils/tmux/Makefile 1.1 +11 -0 ports/sysutils/tmux/files/patch-tty-keys.c (new) _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
State Changed From-To: open->closed Committed. Thanks!