Bug 140978 - [patch] port lang/tclX fix build
Summary: [patch] port lang/tclX fix build
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-11-28 18:10 UTC by Olli Hauer
Modified: 2009-11-30 01:50 UTC (History)
1 user (show)

See Also:


Attachments
patch_lang_tclX.txt (1.22 KB, text/plain)
2009-11-28 18:10 UTC, Olli Hauer
no flags Details
tclX-man-fix.patch (3.25 KB, patch)
2009-11-29 01:31 UTC, Mikhail T.
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Olli Hauer 2009-11-28 18:10:01 UTC
The build stops everytime with the following error:

Begin preprocessing UCB manual files
    preprocessing Tcl.n          tcl/intro/syntax
    ...
    preprocessing tclsh.1        tcl/intro/tclsh
No entry for tclsh in section 1 of the manual
    while executing
"exec man -w $section $manPage"
    (procedure "CopyManPage" line 9)
    invoked from within
"CopyManPage [lindex $ent 0] $tmpFH"
    (procedure "ProcessManFile" line 5)
    invoked from within
"ProcessManFile $ent $tmpFH"
    (procedure "GenInputFile" line 8)
    invoked from within
"GenInputFile $manInfoTbl $tmpFile"
    (file "./unix/tools/bldmanhelp.tcl" line 165)
*** Error code 1
1 error
*** Error code 1

Stop in /a/ports/lang/tclX.
  
Additional build in tinderbox fails with left/missing files.
This patch resolves the issues.
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2009-11-28 18:10:08 UTC
Maintainer of lang/tclX,

Please note that PR ports/140978 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/140978

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2009-11-28 18:10:12 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 3 Mikhail T. 2009-11-29 01:29:39 UTC
Thanks for the report, Olli!

I personally stopped never used TclX' "help files" and so,
unfortunately, allowed things to bit-rot...

When the lang/tcl8x maintainers changed the name of the interpreter's
man-page (from tclsh.1 to tclshVERSION.1), tclX broke...

How about the attached patch? It is looking for each man-page under both
names: page and pageVERSION...

I also incorporated your point regarding resources (not present under
8.5 and above) and a similar point regarding lset.

Let me know, if this works for you, and I'll commit it. Thanks! Yours,

    -mi
Comment 4 Mikhail T. 2009-11-29 01:31:05 UTC
The patch...

    -mi

Comment 5 Olli Hauer 2009-11-29 11:46:45 UTC
Mikhail T. wrote:
...

> How about the attached patch? It is looking for each man-page under both
> names: page and pageVERSION...
> 
> I also incorporated your point regarding resources (not present under
> 8.5 and above) and a similar point regarding lset.
 

Hi Mikhail,

thanks for the patch, it seems tinderbox builds are working now.

I found one interesting difference in the build logs, but I'm not
sure if this is important, see attached diff from build logs.
If this doesn't break anything, please commit your patch.

Send me a note If you need the full build logs, or if I should
do some more build tests.


--
cheers,
olli


--- build_log_diff begins here ---
...
configure: creating ./config.status
config.status: creating Makefile
/usr/bin/sed -i.bak -e	 's,^TCLSH_PROG.*,TCLSH_PROG=/usr/local/bin/tclsh8.5,'  -e 's,TCL_LIBRARY=.*,\\,' /work/a/ports/lang/tclX/work/tclx8.4/Makefile
# Disabling the failing help.test
/bin/mv /work/a/ports/lang/tclX/work/tclx8.4/tests/help.test /work/a/ports/lang/tclX/work/tclx8.4/tests/help.test.dis
===>  Building for tclX-8.4_3
(echo 'package ifneeded Tclx 8.4  [list load [file join $dir libtclx8.4.so] Tclx]' ) > pkgIndex.tcl

...

build without patch or with my patch:
 cc -pipe ... -fPIC -c `echo ./generic/tclXoscmds.c` -o tclXoscmds.o
 cc -pipe ... -fPIC -c `echo ./generic/tclXlgets.c` -o tclXlgets.o

build with your new patch:
 cc -pipe ... -fPIC -c `echo ./generic/tclXoscmds.c` -o tclXoscmds.o
--- build_log_diff ends here ---
Comment 6 dfilter service freebsd_committer freebsd_triage 2009-11-30 01:47:37 UTC
mi          2009-11-30 01:47:22 UTC

  FreeBSD ports repository

  Modified files:
    lang/tclX            Makefile pkg-plist 
    lang/tclX/files      patch-af 
  Log:
  Better handle differences in the set of help-pages.
  Chase the lang/tcl85's decision to install man1/tclsh8.5.1 instead of
  man1/tclsh.1 -- now, when we can't find a man-page foo, we try looking
  for foo$tcl_version.
  
  PR:     ports/140978
  Submitted by:   olli hauer
  
  Revision  Changes    Path
  1.65      +8 -0      ports/lang/tclX/Makefile
  1.5       +15 -6     ports/lang/tclX/files/patch-af
  1.20      +2 -2      ports/lang/tclX/pkg-plist
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 7 Mikhail Teterin freebsd_committer freebsd_triage 2009-11-30 01:48:47 UTC
State Changed
From-To: feedback->closed

Fixed. Thanks for the heads-up and testing!