Bug 141105 - java/jdk16 (and possibly jdk15) build broken after r199827
Summary: java/jdk16 (and possibly jdk15) build broken after r199827
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Greg Lewis
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-12-02 10:50 UTC by Dima Panov
Modified: 2010-02-05 05:30 UTC (History)
0 users

See Also:


Attachments
jdk16.diff (1.37 KB, patch)
2009-12-02 10:50 UTC, Dima Panov
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dima Panov freebsd_committer freebsd_triage 2009-12-02 10:50:01 UTC
java/jdk16 (and possibly jdk15 and other ports) build broken since r199827, which implements sighold, sigignore, sigpause, sigrelse, sigset functions from SUSv4 XSI.
But jdk patchset (bsd-jdk-patches) provide own realization of sigignore() for FreeBSD, and use system sigignore oly on NetBSD.

Patch uses osreldate >= 900002, cause r199827 not bumped osreldate, it need to be corrected.

How-To-Repeat: 

update to r199827 or later, try to build java/jdk16
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2009-12-02 10:50:37 UTC
Responsible Changed
From-To: freebsd-ports-bugs->glewis

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 Dima Panov freebsd_committer freebsd_triage 2009-12-02 17:34:31 UTC
On Wednesday 02 December 2009 20:50:01 FreeBSD-gnats-submit@freebsd.org wrote:
> Thank you very much for your problem report.
> It has the internal identification `ports/141105'.
> The individual assigned to look at your
> report is: freebsd-ports-bugs.
> 
> You can access the state of your problem report at any time
> via this link:
> 
> http://www.freebsd.org/cgi/query-pr.cgi?pr=141105
> 
> >Category:       ports
> >Responsible:    freebsd-ports-bugs
> >Synopsis:       java/jdk16 (and possibly jdk15) build broken after r199827
> >Arrival-Date:   Wed Dec 02 10:50:01 UTC 2009
> 

kib@ bumped osreldate today to 900003 to reflect recent major changes, so
patch was slightly modified to use correct value.
Users, who catched the problems in these days (with 900002 os revsion), should upgrade.

diff -urN /zroot/a/FreeBSD/Work/ports/java/jdk16/Makefile java/jdk16/Makefile
--- /zroot/a/FreeBSD/Work/ports/java/jdk16/Makefile	2009-11-09 08:48:33.000000000 +1000
+++ java/jdk16/Makefile	2009-12-02 19:47:56.198739813 +1000
@@ -284,6 +284,10 @@
 		${BZIP2_CMD} -dc ${DISTDIR}/${PATCHSETFILE} | ${TAR} -xf - && \
 		${CHMOD} -R u+w * && \
 		${PATCH} -p0 < ${WRKDIR}/jdk16.patches
+.if (${OSVERSION} > 900002)
+	@cd ${WRKDIR} &&  \
+		${PATCH} -p2 < ${FILESDIR}/extrapatch-j2se-make-common-Defs-bsd.gmk
+.endif
 
 post-patch:
 	@for file in ${LOCAL_FILES}; do \
diff -urN /zroot/a/FreeBSD/Work/ports/java/jdk16/files/extrapatch-j2se-make-common-Defs-
bsd.gmk java/jdk16/files/extrapatch-j2se-make-common-Defs-bsd.gmk
--- /zroot/a/FreeBSD/Work/ports/java/jdk16/files/extrapatch-j2se-make-common-Defs-bsd.gmk	
1970-01-01 10:00:00.000000000 +1000
+++ java/jdk16/files/extrapatch-j2se-make-common-Defs-bsd.gmk	2009-12-02 
19:47:33.410582100 +1000
@@ -0,0 +1,11 @@
+--- ../../j2se/make/common/Defs-bsd.gmk.orig	2009-12-02 17:58:29.000000000 +1000
++++ ../../j2se/make/common/Defs-bsd.gmk	2009-12-02 18:50:16.981367494 +1000
+@@ -311,7 +311,7 @@
+ override HAVE_FILIOH             = false
+ override HAVE_GETHRTIME          = false
+ override HAVE_GETHRVTIME         = false
+-ifeq ($(OS_VENDOR),NetBSD)
++ifeq ($(OS_VENDOR),FreeBSD)
+ override HAVE_SIGIGNORE          = true
+ endif
+ ifeq ($(OS_VENDOR),Apple)


-- 
Dima "Red Fox" Panov @ Home | C73E 2B72 1FFD 61BD E206 1234 A626 76ED 93E3 B018
Khabarovsk, Russia          | 2D30 2CCB 9984 130C 6F87 BAFC FB8B A09D D539 8F29
KDE@FreeBSD Team | FreeBSD committer since 10.08.2009 | FreeBSD since Sept 1995
Twitter.com:fluffy_khv | Skype:dima.panov | Jabber.org:fluffy.khv | ICQ:1745024
Comment 3 Dima Panov freebsd_committer freebsd_triage 2010-02-01 11:38:49 UTC
On Wednesday 02 December 2009 20:50:01 you wrote:
> Thank you very much for your problem report.
> It has the internal identification `ports/141105'.
> The individual assigned to look at your
> report is: freebsd-ports-bugs.
> 
> You can access the state of your problem report at any time
> via this link:
> 
> http://www.freebsd.org/cgi/query-pr.cgi?pr=141105
> 
> >Category:       ports
> >Responsible:    freebsd-ports-bugs
> >Synopsis:       java/jdk16 (and possibly jdk15) build broken after r199827
> >Arrival-Date:   Wed Dec 02 10:50:01 UTC 2009

Is there any responsible person?

-- 
Dima "Red Fox" Panov @ Home | C73E 2B72 1FFD 61BD E206 1234 A626 76ED 93E3 B018
Khabarovsk, Russia          | 2D30 2CCB 9984 130C 6F87 BAFC FB8B A09D D539 8F29
KDE@FreeBSD Team | FreeBSD committer since 10.08.2009 | FreeBSD since Sept 1995
Twitter.com:fluffy_khv | Skype:dima.panov | Jabber.org:fluffy.khv | ICQ:1745024
Comment 4 Greg Lewis freebsd_committer freebsd_triage 2010-02-02 07:09:19 UTC
State Changed
From-To: open->feedback

Sorry for the delay. 

Note that you also have OS_VERSION to work with in Defs-bsd.gmk, so you 
should be able to come up with a patch doesn't require extra Makefile 
changes to work.  OS_VERSION is defined, in the jdk16 build as the output 
of uname -r.  Have you got time to update the patch to do something along 
those lines?
Comment 5 dfilter service freebsd_committer freebsd_triage 2010-02-05 05:22:39 UTC
glewis      2010-02-05 05:22:31 UTC

  FreeBSD ports repository

  Modified files:
    java/jdk16/files     patch-j2se-common-Defs-bsd.gmk 
  Log:
  . Detect that recent versions of 9-CURRENT have sigignore(3) and configure
    the build correctly for that.
  
    Fixes the build on those versions of 9-CURRENT
  
  PR:                     141105
  Collaboration with:     fluffy@
  
  Revision  Changes    Path
  1.3       +16 -2     ports/java/jdk16/files/patch-j2se-common-Defs-bsd.gmk
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 6 Greg Lewis freebsd_committer freebsd_triage 2010-02-05 05:22:55 UTC
State Changed
From-To: feedback->closed

Committed, with minor changes. Thanks!