Bug 141187 - sysutils/freebsd-snapshot does not check /etc/rc.conf.d
Summary: sysutils/freebsd-snapshot does not check /etc/rc.conf.d
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Philip M. Gollucci
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-12-05 11:00 UTC by amsibamsi
Modified: 2010-01-15 00:47 UTC (History)
0 users

See Also:

Attachments
file.diff (304 bytes, patch)
2009-12-05 11:00 UTC, amsibamsi 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description amsibamsi 2009-12-05 11:00:02 UTC 
Port: freebsd-snapshot

The snapshot command checks whether zfs is enabled on a system. It does so by looking only at /etc/rc.conf. If zfs is configured in /etc/rc.conf.d/zfs, the snapshot command does not know about it, and behaves as zfs was disabled. Consequently snapshots of zfs filesystems can not be managed with the command, although zfs is enabled and running.

Fix: The snapshot command should also source zfs config with "load_rc_config zfs".

Patch attached with submission follows:
How-To-Repeat: Assuming you have zfs_enable="YES" in /etc/rc.conf and "snapshot list" shows zfs snapshots: move the zfs_enable setting to /etc/rc.conf.d/zfs and run "snapshot list" again. No zfs snapshots will show up any more.
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2009-12-06 20:57:26 UTC 
Maintainer of sysutils/freebsd-snapshot,

Please note that PR ports/141187 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/141187

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2009-12-06 20:57:27 UTC 
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 3 Philip M. Gollucci freebsd_committer freebsd_triage 2010-01-13 01:16:30 UTC 
State Changed
From-To: feedback->open

feedback timeout 1 month 6 days
Comment 4 Philip M. Gollucci freebsd_committer freebsd_triage 2010-01-13 01:16:34 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->pgollucci

I'll take it.
Comment 5 dfilter service freebsd_committer freebsd_triage 2010-01-14 23:16:17 UTC 
pgollucci    2010-01-14 23:16:08 UTC

  FreeBSD ports repository

  Modified files:
    sysutils/freebsd-snapshot Makefile 
    sysutils/freebsd-snapshot/files patch-snapshot 
  Log:
  - Use the RC system correct
  
  PR:             ports/141187
  Submitted by:   Anselm Strauss <amsibamsi@gmail.com>
  Approved by:    maintainer timeout (1 month 6 days)
  
  Revision  Changes    Path
  1.11      +1 -0      ports/sysutils/freebsd-snapshot/Makefile
  1.5       +13 -5     ports/sysutils/freebsd-snapshot/files/patch-snapshot
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 6 Philip M. Gollucci freebsd_committer freebsd_triage 2010-01-15 00:47:42 UTC 
State Changed
From-To: open->closed

Committed. Thanks!