Bug 141707 - [patch] multimedia/vlc builds with dirac
Summary: [patch] multimedia/vlc builds with dirac
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Max Brazhnikov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-12-17 11:20 UTC by David Morgan
Modified: 2009-12-19 22:20 UTC (History)
0 users

See Also:

Attachments
file.diff (468 bytes, patch)
2009-12-17 11:20 UTC, David Morgan 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Morgan 2009-12-17 11:20:01 UTC 
multimedia/vlc is currently marked as "BROKEN=doesn't build with dirac" if WITH_DIRAC is defined, or if dirac is present but WITHOUT_DIRAC isn't defined. However, it does build.

Patch attached, although I'm sure you don't need it - just remove the BROKEN= line and change dirac_encoder.0 to dirac_encoder.1

Fix: Patch attached with submission follows:
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2009-12-17 11:20:09 UTC 
Maintainer of multimedia/vlc,

Please note that PR ports/141707 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/141707

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2009-12-17 11:20:10 UTC 
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 3 Joseph S. Atkinson 2009-12-18 14:54:46 UTC 
I will confirm this over the weekend.
Comment 4 Max Brazhnikov freebsd_committer freebsd_triage 2009-12-19 21:59:42 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->makc

I'll take it.
Comment 5 Max Brazhnikov freebsd_committer freebsd_triage 2009-12-19 22:08:32 UTC 
State Changed
From-To: feedback->closed

Committed, with minor changes. Thanks!
Comment 6 dfilter service freebsd_committer freebsd_triage 2009-12-19 22:14:20 UTC 
makc        2009-12-19 22:14:01 UTC

  FreeBSD ports repository

  Modified files:
    multimedia/vlc       Makefile Makefile.inc 
  Log:
  Renable dirac option (default off) [1]
  Remove two dead options (arts and esd) [2]
  Fix QT4 option usage (in preparation for Qt-4.6.0 update)
  
  PR:             based on ports/141707 [1]
  Submitted by:   David Morgan <david.morgan at gmail.com> [1], maintainer via irc [2]
  
  Revision  Changes    Path
  1.207     +0 -0      ports/multimedia/vlc/Makefile
  1.27      +1 -1      ports/multimedia/vlc/Makefile.inc
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 7 Joseph S. Atkinson 2009-12-19 22:14:29 UTC 
Historical Note: This commit was approved by me (maintainer)