Bug 141729 - [patch] audio/akode-plugins-mpc: Makefile fixes for portlint
Summary: [patch] audio/akode-plugins-mpc: Makefile fixes for portlint
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-kde (group)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-12-18 02:40 UTC by Glen Barber
Modified: 2009-12-18 11:10 UTC (History)
0 users

See Also:

Attachments
file.diff (1.80 KB, patch)
2009-12-18 02:40 UTC, Glen Barber 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Glen Barber 2009-12-18 02:40:03 UTC 
portlint finds FATAL errors in the Makefile for this port, such as:
 - use a tab (not space) after a variable name
 - extra item placed in the PORTNAME section
 - extra item placed in the MAINTAINER section

Additionally, portlint warns PLIST_FLAGS should be used when pkg-plist contains 6 or less entries.

Fix: Patch attached with submission follows:
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2009-12-18 02:40:13 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->kde

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 dfilter service freebsd_committer freebsd_triage 2009-12-18 11:06:16 UTC 
fluffy      2009-12-18 11:05:59 UTC

  FreeBSD ports repository

  Modified files:
    audio/akode-plugins-mpc Makefile 
  Removed files:
    audio/akode-plugins-mpc pkg-plist 
  Log:
  - Portlint, tweak plist
  
  PR:             141729
  Submitted by:   glen.j.barber AT gmail.com
  Approved by:    miwi (mentor)
  
  Revision  Changes    Path
  1.23      +13 -10    ports/audio/akode-plugins-mpc/Makefile
  1.4       +0 -3      ports/audio/akode-plugins-mpc/pkg-plist (dead)
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 3 Dima Panov freebsd_committer freebsd_triage 2009-12-18 11:09:32 UTC 
State Changed
From-To: open->closed

Committed. Thanks!