Bug 142849 - Update of security/py-fail2ban
Summary: Update of security/py-fail2ban
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Philip M. Gollucci
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-01-15 05:20 UTC by Krzysztof Stryjek
Modified: 2010-01-18 05:30 UTC (History)
0 users

See Also:


Attachments
file.diff (376 bytes, patch)
2010-01-15 05:20 UTC, Krzysztof Stryjek
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Krzysztof Stryjek 2010-01-15 05:20:01 UTC
	Python fail2ban is very sueful tool. But there is bug with
python2.6, so there should be limitations to python version at port Makefile.

	The fail2ban rc script does not honour fail2ban_flags variable, so
there is no possibility to change start behaviour of fail2ban daemon. Adding
two lines to rcscript solves the problem.

Fix: After adding this patches: one for Makefile and the second for rcscript you
will be albel to start fail2ban server:

----------------------------------------------------------------------------



----------------------------------------------------------------------------

Greetings from Poland
--
Krzysztof Stryjek--Axy6gisa5xcziLs1dEEfH6Y1BywQ98k6HXDuQv9hJ0ZSwobt
Content-Type: text/plain; name="file.diff"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment; filename="file.diff"

--- Makefile.orig	2009-08-23 05:13:33.000000000 +0200
+++ Makefile	2010-01-15 05:59:44.000000000 +0100
@@ -19,7 +19,7 @@
 
 USE_BZIP2=	yes
 
-USE_PYTHON=	yes
+USE_PYTHON=	2.3-2.5
 USE_PYDISTUTILS=	yes
 
 USE_RC_SUBR=	fail2ban
How-To-Repeat: 	After install and setting fail2ban_enable at rc.conf file try to
start daemon using fail2ban rcscript. There will be python coredump while
python2.6 is used.
Comment 1 Philip M. Gollucci 2010-01-15 06:11:47 UTC
> --- Makefile.orig	2009-08-23 05:13:33.000000000 +0200
> +++ Makefile	2010-01-15 05:59:44.000000000 +0100
> -USE_PYTHON=	yes
> +USE_PYTHON=	2.3-2.5
I agree.

> --- files/fail2ban.in.orig	2009-07-16 05:13:16.000000000 +0200
> +++ files/fail2ban.in	2010-01-15 06:16:31.000000000 +0100
> @@ -23,6 +23,9 @@
>  
>  extra_commands="reload jailstatus"
>  
> +# read settings, set defaults
> +load_rc_config ${name}
> +
>  start_cmd="${client} ${fail2ban_flags} start"
>  stop_cmd="${client} ${fail2ban_flags} stop"
>  reload_cmd="${client} ${fail2ban_flags} reload"
That doesn't seem right to me esp since that line is already there but 
lower. If anything the pidfile line should move.

Doug, comments ?

http://people.freebsd.org/~pgollucci/FreeBSD/diffs/security_py-fail2ban-0.8.3.diff



-- 
------------------------------------------------------------------------
1024D/DB9B8C1C B90B FBC3 A3A1 C71A 8E70  3F8C 75B8 8FFB DB9B 8C1C
Philip M. Gollucci (pgollucci@p6m7g8.com) c: 703.336.9354
VP Apache Infrastructure; Member, Apache Software Foundation
Committer,                        FreeBSD Foundation
Consultant,                       P6M7G8 Inc.
Sr. System Admin,                 Ridecharge Inc.

Work like you don't need the money,
love like you'll never get hurt,
and dance like nobody's watching.
Comment 2 Mark Linimon 2010-01-15 11:37:29 UTC
To which port does this apply?
Comment 3 Krzysztof Stryjek 2010-01-15 11:46:19 UTC
Helo,

On Fri, Jan 15, 2010 at 05:37:29AM -0600, Mark Linimon wrote:
> To which port does this apply?
> 

security/py-fail2ban

Sorry for my mistake.

Greetings,
-- 
Krzysztof Stryjek
UNIX administrator/Juniper Networks Specialist
email: wtp (at) bsdserwis (dot) com
http://www.linkedin.com/in/KrzysztofStryjek
GPG fingerprint: 8BD7 40CE 8994 0BBE CE6C  91CD 1292 8959 DC61 0E76

In theory, there is no difference between theory and practice.
In practice, there is.
Comment 4 Mark Linimon freebsd_committer freebsd_triage 2010-01-15 11:47:22 UTC
Responsible Changed
From-To: freebsd-ports-bugs->pgollucci

Fix synopsis and assign.
Comment 5 dfilter service freebsd_committer freebsd_triage 2010-01-18 05:24:51 UTC
pgollucci    2010-01-18 05:24:38 UTC

  FreeBSD ports repository

  Modified files:
    security/py-fail2ban Makefile 
    security/py-fail2ban/files fail2ban.in 
  Log:
  - rc.d fix [2]
  - broken on 2.6, 2.3 is gone, and 2.4 is gone soon, so only 2.5 [1]
  
  PR:             ports/142849 [2]
  Submitted by:   Krzysztof Stryjek <admin@bsdserwis.com> [1], miwi [2]
  
  Revision  Changes    Path
  1.6       +2 -2      ports/security/py-fail2ban/Makefile
  1.3       +2 -2      ports/security/py-fail2ban/files/fail2ban.in
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 6 Philip M. Gollucci freebsd_committer freebsd_triage 2010-01-18 05:24:53 UTC
State Changed
From-To: open->closed

Committed. Thanks!