Bug 143096 - [PATCH] net/AquaGatekeeper: use $SUB_FILES to dynamically adjust pkg-message
Summary: [PATCH] net/AquaGatekeeper: use $SUB_FILES to dynamically adjust pkg-message
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Greg Larkin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-01-23 02:00 UTC by Sevan Janiyan
Modified: 2010-02-24 21:50 UTC (History)
1 user (show)

See Also:


Attachments
AquaGatekeeper-1.22_3.patch (2.38 KB, patch)
2010-01-23 02:00 UTC, Sevan Janiyan
no flags Details | Diff
agk.patch (3.44 KB, patch)
2010-01-23 16:40 UTC, Eugene Grosbein
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sevan Janiyan 2010-01-23 02:00:13 UTC
don't invoke sed manually, use SUB_FILES
use EXAMPLESDIR in pkg-message instead of %%PREFIX%%/share/examples/AquaGatekeeper 

Added file(s):
- files/pkg-message.in

Removed file(s):
- pkg-message

Port maintainer (eugen@grosbein.pp.ru) is cc'd.

Generated with FreeBSD Port Tools 0.99
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2010-01-23 02:00:36 UTC
Maintainer of net/AquaGatekeeper,

Please note that PR ports/143096 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/143096

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2010-01-23 02:00:39 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 3 Sevan Janiyan 2010-01-23 02:05:40 UTC
PKGMESSAGE not PKG-MESSAGE!
Comment 4 Eugene Grosbein 2010-01-23 16:40:56 UTC
The intent is of submitter is good but patch needs some polishing.
While I'm here, make more useful changes to the port:

- support cross-platform installation by suppression of striping for
precompiled binary;
- change MAINTAINER e-mail to another one with less strict antispam policy;
- group ARCH-dependent lines together;
- replace dead WWW link with living mirror;
- make it clearly visible that the software is effectively "abadonware"
for now.

I'm not requesting deletion of the port because I still see some
interest in it periodically
and it still runs fine but there should be clear statement that this
soft is dying.

Corrected patch is in the attachment, please commit.

Eugene Grosbein
Comment 5 Greg Larkin freebsd_committer freebsd_triage 2010-01-28 15:25:22 UTC
Responsible Changed
From-To: freebsd-ports-bugs->glarkin

I'll take it.
Comment 6 Greg Larkin freebsd_committer freebsd_triage 2010-02-24 21:48:34 UTC
State Changed
From-To: feedback->closed

Committed, thank you!
Comment 7 dfilter service freebsd_committer freebsd_triage 2010-02-24 21:48:34 UTC
glarkin     2010-02-24 21:48:26 UTC

  FreeBSD ports repository

  Modified files:
    net/AquaGatekeeper   Makefile pkg-descr 
  Added files:
    net/AquaGatekeeper/files pkg-message.in 
  Removed files:
    net/AquaGatekeeper   pkg-message 
  Log:
  - Use $SUB_FILES to dynamically adjust pkg-message [1]
  - Support cross-platform installation by suppression of stripping for
    precompiled binary [2]
  - Change MAINTAINER e-mail [2]
  - Group ARCH-dependent lines together [2]
  - Replace dead WWW link with living mirror [2]
  - Make it clearly visible that the software is effectively "abandonware"
    for now [2]
  - Added i386 dependency on crypto.so.3 (misc/compat5x)
  
  PR:             ports/143096
  Submitted by:   Sevan Janiyan <venture37@geeklan.co.uk>
  Approved by:    Eugene Grosbein <egrosbein@rdtc.ru> (maintainer) [2]
  Feature safe:   yes
  
  Revision  Changes    Path
  1.14      +11 -9     ports/net/AquaGatekeeper/Makefile
  1.1       +9 -0      ports/net/AquaGatekeeper/files/pkg-message.in (new)
  1.2       +6 -2      ports/net/AquaGatekeeper/pkg-descr
  1.2       +0 -5      ports/net/AquaGatekeeper/pkg-message (dead)
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"