Bug 143361 - [patch] virtualbox-ose*: patches to make the three ports coexist peacefully
Summary: [patch] virtualbox-ose*: patches to make the three ports coexist peacefully
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Virtualbox Team (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-01-30 08:50 UTC by Martin Birgmeier
Modified: 2025-01-05 17:54 UTC (History)
2 users (show)

See Also:

Attachments
file.diff (1.44 KB, patch)
2010-01-30 08:50 UTC, Martin Birgmeier 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Birgmeier 2010-01-30 08:50:01 UTC 
Recently, the following ports have been marked mutually exclusive:
- virtualbox-ose
- virtualbox-ose-additions

However, this is unnecessary, and only the /var/db/ports/*/options file clashes for them (these two, together with virtualbox-ose-kmod, save their options to /var/db/ports/virtualbox-ose/options).

Attached are patches which make all three ports installable at the same time, which is interesting if you use an installation both as a guest and a host.

Fix: See the attached patches.

Patch attached with submission follows:
Comment 1 Philip M. Gollucci freebsd_committer freebsd_triage 2010-02-12 19:32:42 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->pgollucci

I'll take it.
Comment 2 Philip M. Gollucci freebsd_committer freebsd_triage 2010-02-13 06:48:32 UTC 
Responsible Changed
From-To: pgollucci->freebsd-ports-bugs

I'll too slow.
Comment 3 Martin Wilke freebsd_committer freebsd_triage 2010-02-13 08:53:49 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->freebsd-vbox

Over to maintainer.
Comment 4 Mark Linimon freebsd_committer freebsd_triage 2010-02-13 08:57:08 UTC 
Responsible Changed
From-To: freebsd-vbox->vbox

Canonicalize assignment.
Comment 5 Beat Gaetzi freebsd_committer freebsd_triage 2010-02-13 14:18:37 UTC 
Running virtualbox-ose-additions and virtualbox-ose-kmod on the same
machine is known to cause instabilities. This is the reason for
CONFLICTS set. I don't think we should remove this conflict.
Comment 6 Bernhard Froehlich 2010-02-13 14:35:47 UTC 
> From: Beat Gaetzi <beat@FreeBSD.org>
> 
>  Running virtualbox-ose-additions and virtualbox-ose-kmod on the same
>  machine is known to cause instabilities. This is the reason for
>  CONFLICTS set. I don't think we should remove this conflict.

I agree to that. We have had bugreports about instabilities when both
additions and vbox kernel modules were loaded on the same machine and
according to Alexander Eichner both kernel modules have clashing
symbols so the loader could get confused and results can be undefined.

Don't know if that works on Linux or any other supported platform.

-- 
Bernhard Fröhlich
http://www.bluelife.at/
Comment 7 xxllxrvt 2010-02-13 19:03:29 UTC 
In my opinion, CONFLICTS is for separating ports with conflicting 
*installation* requirements. It should not say anything about 
conflicting *runtime* requirements.

In my setup, I can run a FreeBSD client under a FreeBSD host using 
netboot from the same filesystem. The host activates the host parts, the 
client activates the client parts (via /boot/loader.conf and /etc/rc.conf).

It should suffice to add a pkg-message pointing out the possible problems.
Comment 8 dfilter service freebsd_committer freebsd_triage 2010-03-15 20:54:49 UTC 
miwi        2010-03-15 20:54:35 UTC

  FreeBSD ports repository

  Modified files:
    emulators/virtualbox-ose Makefile distinfo pkg-plist 
    emulators/virtualbox-ose/files patch-configure 
                                   patch-src-VBox-Main-include-ConsoleImpl.h 
    emulators/virtualbox-ose-kmod Makefile distinfo pkg-plist 
    emulators/virtualbox-ose-kmod/files vboxnet.in 
    emulators/virtualbox-ose-additions Makefile pkg-plist 
  Added files:
    emulators/virtualbox-ose-kmod/files 
                                        patch-src-VBox-HostDrivers-Support-freebsd-files_vboxdrv 
                                        patch-src-VBox-HostDrivers-VBoxNetAdp-freebsd-files_vboxnetadp 
                                        patch-src-VBox-HostDrivers-VBoxNetFlt-freebsd-files_vboxnetflt 
                                        patch-src-VBox-Runtime-r0drv-freebsd-memobj-r0drv-freebsd.c 
                                        patch-src-VBox-Runtime-r0drv-freebsd-the-freebsd-kernel.h 
                                        patch-src-VBox-VMM-VMMR0-GMMR0.cpp 
  Removed files:
    emulators/virtualbox-ose/files 
                                   patch-src-VBox-Additions-common-VBoxService-VBoxServiceVMInfo.cpp 
                                   patch-src-VBox-Additions-x11-VBoxClient-Makefile.kmk 
                                   patch-src-VBox-HostDrivers-Support-SUPR3HardenedMain.cpp 
                                   patch-src-VBox-Runtime-VBox-log-vbox.cpp 
                                   patch-src-VBox-Runtime-r3-freebsd-rtProcInitExePath-freebsd.cpp 
  Log:
  Presenting VirtualBox 3.1.4 for FreeBSD
  
  Changelog from VirtualBox is available here:
  http://www.virtualbox.org/wiki/Changelog
  
  Changes in the port:
    - VirtualBox and Guest Additions iso updated to 3.1.4
    - Add UNIQUENAME to fix options file clashes between the virtualbox ports [0]
    - Fixed vtophys problems on CURRENT and STABLE kernes newer than
      January 23th [1]
    - Fixed page double wiring issue in rtR0MemObjNativeAllocPage [2]
  
  PR:             ports/143361 [0]
  Submitted by:   Martin Birgmeier <martin.birgmeier AT aon.at> [0]
                  Alexander Eichner <Alexander.Eichner AT Sun.COM> [1]
  Thanks To:      All testers on emulation@ and current@ [1]
                  Giovanni Trematerra <giovanni.trematerra AT gmail.com> [1]
                  Ian Freislich <ianf AT clue.co.za> [1]
  Reported by:    Alan Cox <alc AT cs dot rice dot edu> [2]
  
  Revision  Changes    Path
  1.3       +2 -1      ports/emulators/virtualbox-ose-additions/Makefile
  1.3       +3 -3      ports/emulators/virtualbox-ose-additions/pkg-plist
  1.17      +3 -3      ports/emulators/virtualbox-ose-kmod/Makefile
  1.8       +3 -3      ports/emulators/virtualbox-ose-kmod/distinfo
  1.1       +10 -0     ports/emulators/virtualbox-ose-kmod/files/patch-src-VBox-HostDrivers-Support-freebsd-files_vboxdrv (new)
  1.1       +9 -0      ports/emulators/virtualbox-ose-kmod/files/patch-src-VBox-HostDrivers-VBoxNetAdp-freebsd-files_vboxnetadp (new)
  1.1       +9 -0      ports/emulators/virtualbox-ose-kmod/files/patch-src-VBox-HostDrivers-VBoxNetFlt-freebsd-files_vboxnetflt (new)
  1.1       +870 -0    ports/emulators/virtualbox-ose-kmod/files/patch-src-VBox-Runtime-r0drv-freebsd-memobj-r0drv-freebsd.c (new)
  1.4       +13 -0     ports/emulators/virtualbox-ose-kmod/files/patch-src-VBox-Runtime-r0drv-freebsd-the-freebsd-kernel.h (new)
  1.1       +13 -0     ports/emulators/virtualbox-ose-kmod/files/patch-src-VBox-VMM-VMMR0-GMMR0.cpp (new)
  1.2       +0 -0      ports/emulators/virtualbox-ose-kmod/files/vboxnet.in
  1.12      +4 -3      ports/emulators/virtualbox-ose-kmod/pkg-plist
  1.17      +2 -3      ports/emulators/virtualbox-ose/Makefile
  1.8       +6 -6      ports/emulators/virtualbox-ose/distinfo
  1.5       +5 -5      ports/emulators/virtualbox-ose/files/patch-configure
  1.2       +0 -10     ports/emulators/virtualbox-ose/files/patch-src-VBox-Additions-common-VBoxService-VBoxServiceVMInfo.cpp (dead)
  1.2       +0 -20     ports/emulators/virtualbox-ose/files/patch-src-VBox-Additions-x11-VBoxClient-Makefile.kmk (dead)
  1.2       +0 -33     ports/emulators/virtualbox-ose/files/patch-src-VBox-HostDrivers-Support-SUPR3HardenedMain.cpp (dead)
  1.2       +9 -9      ports/emulators/virtualbox-ose/files/patch-src-VBox-Main-include-ConsoleImpl.h
  1.2       +0 -82     ports/emulators/virtualbox-ose/files/patch-src-VBox-Runtime-VBox-log-vbox.cpp (dead)
  1.2       +0 -81     ports/emulators/virtualbox-ose/files/patch-src-VBox-Runtime-r3-freebsd-rtProcInitExePath-freebsd.cpp (dead)
  1.12      +2 -0      ports/emulators/virtualbox-ose/pkg-plist
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 9 Beat Gaetzi freebsd_committer freebsd_triage 2010-03-16 07:04:04 UTC 
State Changed
From-To: open->closed

Committed. Thanks!
Comment 10 Martin Birgmeier 2025-01-05 14:20:40 UTC 
This has finally been resolved by commit b4a6bc8744f4f15b0e510af1553afeb1c8a027b3.

-- Martin
Comment 11 Vladimir Druzenko freebsd_committer freebsd_triage 2025-01-05 17:42:38 UTC 
(In reply to Martin Birgmeier from comment #10)
Less than 15 years! :-D
Comment 12 Martin Birgmeier 2025-01-05 17:54:31 UTC 
(In reply to Vladimir Druzenko from comment #11)

You are right, and a heartfelt thank you for all your work, Vladimir!

-- Martin