The bsd.squirrelmail.mk is a Makefile include used by squirrelmail-plugin ports which provides common routines for correctly installing and activating plugins. The include file sets USE_PHP=yes unconditionally. If a plugin requires PHP extensions, this setting overrides any USE_PHP setting (e.g., USE_PHP=xmlrpc) in the plugin Makefile. Fix: Modify bsd.squirrelmail.mk to set USE_PHP only if unset (i.e., ?= operator). The attached patch does exactly this. Patch attached with submission follows: How-To-Repeat: 1. Create a Makefile that sets USE_PHP to something other than yes; 2. Run make -V USE_PHP and observe your setting; 3. Modify the Makefile to include ${PORTSDIR}/mail/squirrelmail/bsd.squirrelmail.mk after your USE_PHP setting; 4. Run make -V USE_PHP again and observe USE_PHP is now set to "yes" instead of your setting;
Responsible Changed From-To: freebsd-ports-bugs->tabthorpe Over to maintainer (via the GNATS Auto Assign Tool)
tabthorpe 2010-02-02 03:25:57 UTC FreeBSD ports repository Modified files: mail/squirrelmail bsd.squirrelmail.mk Log: - Set USE_PHP?= yes, so selected PHP modules can override setting PR: ports/143447 Submitted by: Darren Pilgrim <darren.pilgrim gmail.com> Revision Changes Path 1.7 +3 -3 ports/mail/squirrelmail/bsd.squirrelmail.mk _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
State Changed From-To: open->closed Committed. Thanks!