Bug 143683 - devel/git depends on iconv even when ICONV option not selected
Summary: devel/git depends on iconv even when ICONV option not selected
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Wesley Shields
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-02-08 23:00 UTC by Stef Walter
Modified: 2010-02-14 17:10 UTC (History)
0 users

See Also:

Attachments
file.diff (237 bytes, patch)
2010-02-08 23:00 UTC, Stef Walter 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Stef Walter 2010-02-08 23:00:10 UTC 
Recent versions of git started depending on libiconv, even when the ICON build option is not selected. For example git-1.6.6.1

This is because the git Makefile sets NEEDS_LIBICONV if uname contains FreeBSD.

Fix: Attaching a patch

Patch attached with submission follows:
How-To-Repeat: Build devel/git port without the ICONV option. Then:

$ ldd /usr/local/bin/git
Comment 1 Mark Linimon freebsd_committer freebsd_triage 2010-02-09 00:47:14 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->wxs

Fix synopsis and assign.
Comment 2 dfilter service freebsd_committer freebsd_triage 2010-02-14 17:06:14 UTC 
wxs         2010-02-14 17:06:00 UTC

  FreeBSD ports repository

  Modified files:
    devel/git            Makefile distinfo pkg-plist 
    devel/git/files      git_daemon.in 
  Log:
  - Update to 1.6.6.2
  - Switch to including bsd.port.options.mk
  - Don't link with libiconv when the option is not selected [1]
  - Add --reuseaddr to git_daemon_flags [2]
  
  PR:             [1]: ports/143683
                  [2]: ports/143275
  Submitted by:   [1]: Stef Walter <stef@memberwebs.com>
                  [2]: Philippe Pepiot <phil@philpep.org>
  
  Revision  Changes    Path
  1.77      +3 -3      ports/devel/git/Makefile
  1.51      +9 -9      ports/devel/git/distinfo
  1.3       +2 -2      ports/devel/git/files/git_daemon.in
  1.48      +1 -0      ports/devel/git/pkg-plist
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 3 Wesley Shields freebsd_committer freebsd_triage 2010-02-14 17:06:34 UTC 
State Changed
From-To: open->closed

Committed. Thanks!