Bug 143729 - MAINTAINER UPDATE mail/p5-Mail-SpamAssassin FIX some 330 issues
Summary: MAINTAINER UPDATE mail/p5-Mail-SpamAssassin FIX some 330 issues
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Gabor Kovesdan
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-02-10 17:50 UTC by Michael Scheidell
Modified: 2010-02-11 16:50 UTC (History)
0 users

See Also:


Attachments
file.diff (4.00 KB, patch)
2010-02-10 17:50 UTC, Michael Scheidell
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Scheidell 2010-02-10 17:50:01 UTC
portupgrade or make deinstall/reinstall seemed to work, but make from a greenfields install didn't always work.

SA needs to have tar-archive and net-ip in build_depends,
move a lot of dependencies from run_depends to build_depends.

put tar_archive and net_ip first.

also, added in patch for
patch-Parser.pm 

Note: SOMETIMES I needed to run a 'make clean' in ../p5-Mail-SpamAssassin if there were old p5-* files still around.

if you get a missing Makefile, or stop when you build, then run make clean first.

Fix: this patch, bump port version to 2
thanks to several people who found this, and Gabor for getting it most of the way there with port version 1.


Patch attached with submission follows:
How-To-Repeat: make
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2010-02-10 17:50:11 UTC
Responsible Changed
From-To: freebsd-ports-bugs->gabor

gabor@ wants his PRs (via the GNATS Auto Assign Tool)
Comment 2 Michael Scheidell 2010-02-11 15:09:28 UTC
one more patch to solve Jeremy's problem:
if you have perl < 5.10.0 and don't select DKIM.  you need this

(and since _2 hasn't been posted yet, maybe it can be included in _2.)

diff -bBru /var/tmp/SA330_2/ ./
diff -bBru /var/tmp/SA330_2/Makefile ./Makefile
--- /var/tmp/SA330_2/Makefile    2010-02-10 12:33:18.000000000 -0500
+++ ./Makefile    2010-02-11 10:06:06.000000000 -0500
@@ -105,7 +105,7 @@
  .else
  .if !defined(WITH_DKIM)
  .if   ${PERL_LEVEL} < 501000
-BUILD_DEPENDS=+    p5-Digest-SHA1>=2.11:${PORTSDIR}/security/p5-Digest-SHA1
+BUILD_DEPENDS+=    p5-Digest-SHA1>=2.11:${PORTSDIR}/security/p5-Digest-SHA1
  .endif
  .endif
  .endif

-- 
Michael Scheidell, CTO
Phone: 561-999-5000, x 1259
 > *| *SECNAP Network Security Corporation

    * Certified SNORT Integrator
    * 2008-9 Hot Company Award Winner, World Executive Alliance
    * Five-Star Partner Program 2009, VARBusiness
    * Best Anti-Spam Product 2008, Network Products Guide
    * King of Spam Filters, SC Magazine 2008


______________________________________________________________________
This email has been scanned and certified safe by SpammerTrap(r). 
For Information please see http://www.secnap.com/products/spammertrap/
______________________________________________________________________  
Comment 3 dfilter service freebsd_committer freebsd_triage 2010-02-11 16:41:44 UTC
gabor       2010-02-11 16:41:35 UTC

  FreeBSD ports repository

  Modified files:
    mail/p5-Mail-SpamAssassin Makefile 
  Added files:
    mail/p5-Mail-SpamAssassin/files patch-Parser.pm 
  Log:
  - Some dependency adjustments
  - Fix syntax error, which was kept undetected so far because of the
    optional case [1]
  
  PR:             ports/143729
  Submitted by:   Michael Scheidell <scheidell@secnap.net>
  Reported by:    koitsu [1]
  
  Revision  Changes    Path
  1.130     +16 -18    ports/mail/p5-Mail-SpamAssassin/Makefile
  1.1       +13 -0     ports/mail/p5-Mail-SpamAssassin/files/patch-Parser.pm (new)
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 4 Gabor Kovesdan freebsd_committer freebsd_triage 2010-02-11 16:41:55 UTC
State Changed
From-To: open->closed

Committed, thanks!