Bug 144105 - ftp/proftpd-devel update
Summary: ftp/proftpd-devel update
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Wesley Shields
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-02-19 11:50 UTC by Bartłomiej Syryjczyk
Modified: 2010-03-14 01:40 UTC (History)
0 users

See Also:


Attachments
file.diff (1.28 KB, patch)
2010-02-19 11:50 UTC, Bartłomiej Syryjczyk
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Bartłomiej Syryjczyk 2010-02-19 11:50:00 UTC
New version of ProFTPd (ftp/proftpd-devel)

Fix: Patch attached with submission follows:
Comment 1 Mark Linimon freebsd_committer freebsd_triage 2010-02-19 13:25:20 UTC
State Changed
From-To: open->closed

see ports/144106. 


Comment 2 Mark Linimon freebsd_committer freebsd_triage 2010-02-19 13:25:20 UTC
Responsible Changed
From-To: freebsd-bugs->freebsd-ports-bugs
Comment 3 Mark Linimon freebsd_committer freebsd_triage 2010-02-19 15:15:52 UTC
State Changed
From-To: closed->open

Fix synopsis.
Comment 4 Wesley Shields freebsd_committer freebsd_triage 2010-03-04 19:45:41 UTC
Responsible Changed
From-To: freebsd-ports-bugs->wxs

I'll take it.
Comment 5 Wesley Shields freebsd_committer freebsd_triage 2010-03-06 02:27:46 UTC
Thank you for your submission, however this port does not build on a
recent current system. The problem is related to the utmp changes in
current.

cc -DHAVE_CONFIG_H  -DFREEBSD9_0 -DFREEBSD9 -I.. -I../include -I/include
-O2 -pipe -DHAVE_OPENSSL -I/usr/include -fno-strict-aliasing -Wall -c
wtmp.c
In file included from ../include/conf.h:241,
                 from wtmp.c:27:
/usr/include/sys/termios.h:3:2: warning: #warning "this file includes
<sys/termios.h> which is deprecated, use <termios.h> instead"
wtmp.c: In function 'log_wtmp':
wtmp.c:60: error: 'WTMPX_FILE' undeclared (first use in this function)
wtmp.c:60: error: (Each undeclared identifier is reported only once
wtmp.c:60: error: for each function it appears in.)
wtmp.c:86: error: 'struct utmpx' has no member named 'ut_syslen'
gmake[1]: *** [wtmp.o] Error 1
gmake[1]: Leaving directory
`/work/a/ports/ftp/proftpd-devel/work/proftpd-1.3.3rc4/src'
gmake: *** [src] Error 2
*** Error code 1

The line numbers may be slightly off because I took a quick stab at
fixing this. Can you please investigate this and get back to me?

Also, this port is currently without a maintainer. Would you be willing
to maintain this port?

-- WXS
Comment 6 TJ Saunders 2010-03-08 21:40:22 UTC
I just saw pr ports/144105 regarding proftpd, and would be more than happy 
to update the proftpd code to avoid these issues.  Unfortunately, I don't 
have access to a FreeBSD machine new enough (8.0 or later); would you have 
such a machine to which I could get a temporary shell account, with gcc, 
for working on fixes?

Cheers,
TJ

~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

   To believe in something, and not to live, is dishonest.

   	-Mahatma Gandhi

~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Comment 7 Wesley Shields freebsd_committer freebsd_triage 2010-03-09 16:51:31 UTC
On Tue, Mar 09, 2010 at 05:17:46PM +0100, Bartlomiej Syryjczyk wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> W dniu 2010-03-06 03:27, Wesley Shields pisze:
> > Thank you for your submission, however this port does not build on a
> > recent current system. The problem is related to the utmp changes in
> > current.
> > 
> > cc -DHAVE_CONFIG_H  -DFREEBSD9_0 -DFREEBSD9 -I.. -I../include -I/include
> > -O2 -pipe -DHAVE_OPENSSL -I/usr/include -fno-strict-aliasing -Wall -c
> > wtmp.c
> > In file included from ../include/conf.h:241,
> >                  from wtmp.c:27:
> > /usr/include/sys/termios.h:3:2: warning: #warning "this file includes
> > <sys/termios.h> which is deprecated, use <termios.h> instead"
> > wtmp.c: In function 'log_wtmp':
> > wtmp.c:60: error: 'WTMPX_FILE' undeclared (first use in this function)
> > wtmp.c:60: error: (Each undeclared identifier is reported only once
> > wtmp.c:60: error: for each function it appears in.)
> > wtmp.c:86: error: 'struct utmpx' has no member named 'ut_syslen'
> > gmake[1]: *** [wtmp.o] Error 1
> > gmake[1]: Leaving directory
> > `/work/a/ports/ftp/proftpd-devel/work/proftpd-1.3.3rc4/src'
> > gmake: *** [src] Error 2
> > *** Error code 1
> > 
> > The line numbers may be slightly off because I took a quick stab at
> > fixing this. Can you please investigate this and get back to me?
> 8.0-RELEASE?

It built fine on 8.0. Current has some utmp changes so you'll need a
fairly recent -current system to test this.

> > Also, this port is currently without a maintainer. Would you be willing
> > to maintain this port?
> OK, but I don't use this software often.

Once we have it working on -current I'll go ahead and change maintainer
over to you.
Comment 8 dfilter service freebsd_committer freebsd_triage 2010-03-14 01:38:29 UTC
wxs         2010-03-14 01:38:21 UTC

  FreeBSD ports repository

  Modified files:
    ftp/proftpd-devel    Makefile distinfo 
  Added files:
    ftp/proftpd-devel/files patch-src__wtmp.c 
  Log:
  - Update to 1.3.3rc4 [1]
  - Fix on current (utmp related) [2]
  - Pass maintainer to submitter
  
  PR:             ports/144105
  Submitted by:   [1]: Bartlomiej Syryjczyk <guzik@anka.net.pl>
                  [2]: TJ Saunders <tj@castaglia.org> (upstream maintainer)
  
  Revision  Changes    Path
  1.154     +2 -3      ports/ftp/proftpd-devel/Makefile
  1.50      +3 -9      ports/ftp/proftpd-devel/distinfo
  1.1       +47 -0     ports/ftp/proftpd-devel/files/patch-src__wtmp.c (new)
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 9 Wesley Shields freebsd_committer freebsd_triage 2010-03-14 01:38:37 UTC
State Changed
From-To: open->closed

Committed. Thanks!