Bug 144119 - audio/mumble 1.2.x does not build client compatible to 1.1.x [patch]
Summary: audio/mumble 1.2.x does not build client compatible to 1.1.x [patch]
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-02-20 00:10 UTC by Sascha Schneider
Modified: 2010-03-31 21:40 UTC (History)
0 users

See Also:


Attachments
file.diff (1.96 KB, patch)
2010-02-20 00:10 UTC, Sascha Schneider
no flags Details | Diff
mumble11x.patch (2.23 KB, patch)
2010-02-21 09:34 UTC, Sascha Schneider
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sascha Schneider 2010-02-20 00:10:01 UTC
Mumble 1.2.x is not compatible to Murmur 1.1.x, therefore Mumble is able to build a client that is, which is called for that server versions, if the user requests it.

The current port does not allow that compatible client to be installed, therefore breaking connectivity to Murmur 1.1.x, which can lead to users after updating to current port not being able to use the servers they used to.

I built a patch which lets the user decide if he wants that extra client or not.

Fix: Apply the attached patch, do "make configure" and select "MUMBLE11X". Rebuild and reinstall and now it works even with older servers.

Patch attached with submission follows:
How-To-Repeat: use mumble 1.2.x and try to connect to a 1.1.x Murmur. Mumble will ask if you want it to start a compatible client, which it cannot, because it is not installed.
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2010-02-20 00:10:09 UTC
Maintainer of audio/mumble,

Please note that PR ports/144119 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/144119

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2010-02-20 00:10:12 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 3 marius 2010-02-20 08:38:08 UTC
Dear committer,
I approve this patch. Please change the default value of the new
MUMBLE11X option to off and remove the MAKE_JOBS_SAFE line from the
Makefile, it didn't work for me with this patch.

Sascha, thanks for your contribution! I hoped noone would need 1.1.x
but if you do it's ok :)
Comment 4 Mark Linimon freebsd_committer freebsd_triage 2010-02-20 09:44:28 UTC
State Changed
From-To: feedback->open

Approved, with some suggested changes.
Comment 5 Sascha Schneider 2010-02-21 09:34:22 UTC
In the attached I changed default state of MUBLE11X to off as requested and removed
MAKE_JOBS_SAFE. Additionally I added PORTREVISION=1, to make the change
apparent.
Comment 6 Sascha Schneider 2010-03-21 09:08:43 UTC
I don't want to seem hasty, but this PR is in it's current stare for a
month now. Is there anything I can do to have the patch applied and
therefore the PR be closed?

Please tell me what it is that is keeping it in this state.

Thanks in advance,
Sascha
Comment 7 marius 2010-03-28 22:43:17 UTC
I don't know. Some comitter please commit this :)
Comment 8 Pav Lucistnik freebsd_committer freebsd_triage 2010-03-31 21:29:10 UTC
State Changed
From-To: open->closed

Committed, thanks!
Comment 9 dfilter service freebsd_committer freebsd_triage 2010-03-31 21:30:23 UTC
pav         2010-03-31 20:30:10 UTC

  FreeBSD ports repository

  Modified files:
    audio/mumble         Makefile pkg-plist 
  Log:
  - Add mumble11x option, default to off
  
  PR:             ports/144119
  Submitted by:   Sascha Schneider <suntsu@suntsu.org>
  Approved by:    maintainer
  
  Revision  Changes    Path
  1.10      +12 -3     ports/audio/mumble/Makefile
  1.3       +2 -1      ports/audio/mumble/pkg-plist
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"