I will follow up with a few other fonts from the same author, installing them to the same directory. I considered putting them into a single port, but they aren't particularly related, and they are updated and versioned separately, so I settled on making them separate ports. Although the port passes "portlint" and "port test", it does leave behind a directory and the fonts.scale and fonts.dir files in it. This is because of the intent to have multiple ports installing to that directory. This font is called Isabella because it is based on the calligraphic hand used in the Isabella Breviary, made around 1497, in Holland, for Isabella of Castille, the first queen of united Spain.
Can I get some feedback on this port? I don't care how long it takes to get committed, but I want to hear whether it's okay before I use it as a template for a few other fonts. For some reason, I haven't seen the PR show up on the bugs list, so I'm not sure whether anybody knew it was there to look at...
Responsible Changed From-To: freebsd-ports-bugs->makc I'll take it.
> Although the port passes "portlint" and "port test", it does leave > behind a directory and the fonts.scale and fonts.dir files in it. > This is because of the intent to have multiple ports installing to > that directory. Ports shouldn't leave files/directories. I'd suggest you install each font into separate directory and add all files/dirs to plist. Alternatively, fonts.scale and fonts.dir can be generated on the fly (so you can install all fonts into the same directory), but at the cost of adding mkfontscale and mkfontdir as run-time dependencies for your ports. What would you prefer? One note on your port. Documentation files should be installed into DOCSDIR (${PREFIX}/share/doc/${PORTNAME} by default) in accordance with hier(7). Max
State Changed From-To: open->feedback Wait for submitter's response.
Max Brazhnikov <makc@freebsd.org> writes: >> Although the port passes "portlint" and "port test", it does leave >> behind a directory and the fonts.scale and fonts.dir files in it. >> This is because of the intent to have multiple ports installing to >> that directory. > > Ports shouldn't leave files/directories. I'd suggest you install each font > into separate directory and add all files/dirs to plist. > Alternatively, fonts.scale and fonts.dir can be generated on the fly (so you > can install all fonts into the same directory), but at the cost of adding > mkfontscale and mkfontdir as run-time dependencies for your ports. What would > you prefer? The latter is what my port was already doing, but I forgot to add the dependencies. The files are generated on the fly, and are left behind on deinstall. I could remove them, but when there are more fonts in the same directory, removing them reliably would be tricky. I'd more comfortable just leaving a message warning the user on deinstall. I hadn't thought of it, but I should run mkfontscale and mkfontdir at that time also, as it will be necessary when there are other fonts in the same spot. > One note on your port. Documentation files should be installed into DOCSDIR > (${PREFIX}/share/doc/${PORTNAME} by default) in accordance with hier(7). Right. I'll fix that too.
On Fri, 21 May 2010 15:50:13 -0400, Lowell Gilbert wrote: > The latter is what my port was already doing, but I forgot to add the > dependencies. The files are generated on the fly, and are left behind > on deinstall. I could remove them, but when there are more fonts in the > same directory, removing them reliably would be tricky. I'd more > comfortable just leaving a message warning the user on deinstall. I > hadn't thought of it, but I should run mkfontscale and mkfontdir at that > time also, as it will be necessary when there are other fonts in the > same spot. Please, check the modified port http://people.freebsd.org/~makc/ports/isabella.tar.bz2 and if you are ok with it, I commit it soon. Max
Max Brazhnikov <makc@freebsd.org> writes: > Please, check the modified port > http://people.freebsd.org/~makc/ports/isabella.tar.bz2 > and if you are ok with it, I commit it soon. Looks great. Thanks!
makc 2010-05-24 21:36:32 UTC FreeBSD ports repository Added files: x11-fonts/isabella Makefile distinfo pkg-descr pkg-plist Log: Add new port x11-fonts/isabella: This font is called Isabella because it is based on the calligraphic hand used in the Isabella Breviary, made around 1497, in Holland, for Isabella of Castille, the first queen of united Spain. WWW: http://www.thibault.org/fonts/isabella/ PR: based on ports/144624 Submitted by: Lowell Gilbert <lgfbsd at be-well.ilk.org> Revision Changes Path 1.1 +40 -0 ports/x11-fonts/isabella/Makefile (new) 1.1 +3 -0 ports/x11-fonts/isabella/distinfo (new) 1.1 +5 -0 ports/x11-fonts/isabella/pkg-descr (new) 1.1 +8 -0 ports/x11-fonts/isabella/pkg-plist (new) _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
State Changed From-To: feedback->closed Committed with some modifications. Thanks!