Bug 144876 - [patch] net-mgmt/nfsen won't work with rrdtool 1.4.2 (current in ports)
Summary: [patch] net-mgmt/nfsen won't work with rrdtool 1.4.2 (current in ports)
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Pav Lucistnik
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-03-19 15:50 UTC by Vincent Hoffman-Kazlauskas
Modified: 2010-03-31 22:00 UTC (History)
0 users

See Also:


Attachments
file.diff (396 bytes, patch)
2010-03-19 15:50 UTC, Vincent Hoffman-Kazlauskas
no flags Details | Diff
patch-libexec-NfSenRRD.pm.txt (345 bytes, patch)
2010-03-23 16:35 UTC, vhoffman
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Vincent Hoffman-Kazlauskas 2010-03-19 15:50:01 UTC
nfsen checks for rrdtool version to set the offset, this check fails for 
$rrd_version < 1.4
as the author hasn't tested with higher versions at this time. However
I've been running nfsen with rrdtool 1.4.2 for approx a week now with
no issues seen.

Fix: Patch attached. follows
----------------cut-----------------
How-To-Repeat: upgrade to latest rrdtool and restart nfsen
Comment 1 vhoffman 2010-03-23 16:35:28 UTC
This actually breaks the install not just running the port after upgrade.
I have attached the patch as a file created using make makepatch also.

-- 
---------------------
Vincent Hoffman
Systems Administrator
Namesco Limited

Main Line:	+44 (0)845 363 3630
Main Fax:	+44 (0)845 363 3631
Tech Support:	+44 (0)845 363 3634
Email:		vhoffman@names.co.uk
Website:	http://www.names.co.uk
Address:       7th Floor City Reach, 5 Greenwich View Place, London E14
9NN.

Namesco Limited (Registration No: 3913408) is incorporated in England and Wales with its registered office at Acton House, Perdiswell Park, Worcester, WR3 7GD.
 
Information contained in this e-mail is intended for the use of the addressee only, and is confidential. If you have received this email in error please notify the sender immediately. Any dissemination, distribution, copying or use of this communication without prior permission of the addressee is strictly prohibited. The contents of an attachment to this e-mail may contain software viruses, which could damage your own computer system. While Namesco has taken every reasonable precaution to minimise this ri sk, we cannot accept liability for any damage, which you sustain as a result of software viruses. You should carry out your own virus checks before opening the attachment.
 
Please note that any views or opinions presented in this email are solely those of the author and do not necessarily represent those of the company.
 
© 2009 Namesco Limited. All rights reserved.
Comment 2 Pav Lucistnik freebsd_committer freebsd_triage 2010-03-31 13:47:46 UTC
State Changed
From-To: open->feedback

Asked maintainer for approval 


Comment 3 Pav Lucistnik freebsd_committer freebsd_triage 2010-03-31 13:47:46 UTC
Responsible Changed
From-To: freebsd-ports-bugs->pav

Asked maintainer for approval
Comment 4 Pav Lucistnik freebsd_committer freebsd_triage 2010-03-31 13:48:26 UTC
Dear maintainer of FreeBSD port net-mgmt/nfsen, please take a look at

  http://www.freebsd.org/cgi/query-pr.cgi?pr=144876

Do you approve the proposed patch?

-- 
Pav Lucistnik <pav@oook.cz>
              <pav@FreeBSD.org>

/usr/src scares me.  I'm just not man enough to commit there.
Comment 5 Mohacsi Janos 2010-03-31 15:57:03 UTC
Approved.
Comment 6 Pav Lucistnik freebsd_committer freebsd_triage 2010-03-31 21:58:11 UTC
State Changed
From-To: feedback->closed

Committed, thanks!
Comment 7 dfilter service freebsd_committer freebsd_triage 2010-03-31 21:58:40 UTC
pav         2010-03-31 20:58:26 UTC

  FreeBSD ports repository

  Modified files:
    net-mgmt/nfsen       Makefile 
  Added files:
    net-mgmt/nfsen/files nfsen.in patch-libexec_NfSenRRD.pm 
  Removed files:
    net-mgmt/nfsen/files nfsen.sh.in 
  Log:
  - Provide rc.subr script
  
  PR:             ports/144384
  Submitted by:   geoffroy desvernay <dgeo@centrale-marseille.fr>
  Approved by:    maintainer
  
  - Allow to work with rrdtool 1.4.x
  
  PR:             ports/144876
  Submitted by:   Vincent Hoffman <vince@unsane.co.uk>
  Approved by:    maintainer
  
  Revision  Changes    Path
  1.16      +3 -1      ports/net-mgmt/nfsen/Makefile
  1.1       +24 -0     ports/net-mgmt/nfsen/files/nfsen.in (new)
  1.3       +0 -86     ports/net-mgmt/nfsen/files/nfsen.sh.in (dead)
  1.1       +11 -0     ports/net-mgmt/nfsen/files/patch-libexec_NfSenRRD.pm (new)
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"