Bug 145207 - [patch] security/vpnc fix rc.d script return value
Summary: [patch] security/vpnc fix rc.d script return value
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Emanuel Haupt
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-03-30 16:00 UTC by kamikaze
Modified: 2010-03-30 17:40 UTC (History)
0 users

See Also:

Attachments
file.diff (543 bytes, patch)
2010-03-30 16:00 UTC, kamikaze 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description kamikaze 2010-03-30 16:00:17 UTC 
The rc.d script always returns 0, even when establishing the connection fails.

This is cause by the following code:

if ! $command --local-port 0 $current $vpnc_flags; then
	status=$?
	... error handling ...
	return $status
fi


! $command ...
returns 0 in case of an error, which is what will be assigned to status, instead of the error code issued by vpnc.

Fix: Patch attached with submission follows:
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2010-03-30 16:00:30 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->ehaupt

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 dfilter service freebsd_committer freebsd_triage 2010-03-30 17:37:08 UTC 
ehaupt      2010-03-30 16:36:59 UTC

  FreeBSD ports repository

  Modified files:
    security/vpnc        Makefile 
    security/vpnc/files  vpnc.in 
  Log:
  Fix rc.d script return value
  
  PR:             145207
  Submitted by:   Dominic Fandrey <kamikaze@bsdforen.de>
  
  Revision  Changes    Path
  1.44      +1 -1      ports/security/vpnc/Makefile
  1.7       +3 -2      ports/security/vpnc/files/vpnc.in
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 3 Emanuel Haupt freebsd_committer freebsd_triage 2010-03-30 17:37:18 UTC 
State Changed
From-To: open->closed

Committed, thanks!