Update MASTER_SITES with a more reliable location. Fix: Patch attached with submission follows:
Maintainer of net/opentracker, Please note that PR ports/145637 has just been submitted. If it contains a patch for an upgrade, an enhancement or a bug fix you agree on, reply to this email stating that you approve the patch and a committer will take care of it. The full text of the PR can be found at: http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/145637 -- Edwin Groothuis via the GNATS Auto Assign Tool edwin@FreeBSD.org
State Changed From-To: open->feedback Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Thanks Glen, I've also noticed that the port uses %%RC_SUBR%%, so I've taken that out in the attached patch, which also has Glen's changes in it. Please use this new patch, which is attached and is also at http://www.bayofrum.net/~chris/patches/opentracker_rc_subr.patch Chris
Responsible Changed From-To: freebsd-ports-bugs->sahil I'll take it.
State Changed From-To: feedback->open Maintainer has provided revised patch.
Both patches contain some mistakes. The latest version of net/opentracker in ports already has the RC_SUBR fix; see: http://www.freebsd.org/cgi/cvsweb.cgi/ports/net/opentracker/files/opentracker.in.diff?r1=1.1;r2=1.2 And the original patch was missing a backslash which is required when you define a variable (in this case, MASTER_SITES) over multiple lines. I also suggest the use of the ${PORTNAME} variable where possible. Please let me know if you approve the attached patch. -- Sahil Tandon <sahil@FreeBSD.org>
The intent in my original patch was to remove my 'dev-urandom' domain. -- Glen Barber Sent from my Android. On Apr 14, 2010 8:34 PM, "Sahil Tandon" <sahil@freebsd.org> wrote: Both patches contain some mistakes. The latest version of net/opentracker in ports already has the RC_SUBR fix; see: http://www.freebsd.org/cgi/cvsweb.cgi/ports/net/opentracker/files/opentracker.in.diff?r1=1.1;r2=1.2 And the original patch was missing a backslash which is required when you define a variable (in this case, MASTER_SITES) over multiple lines. I also suggest the use of the ${PORTNAME} variable where possible. Please let me know if you approve the attached patch. -- Sahil Tandon <sahil@FreeBSD.org>
On Wed, 14 Apr 2010, Glen Barber wrote: > The intent in my original patch was to remove my 'dev-urandom' domain. See attached. Chris - are you OK with the other changes? As I mentioned in my previous follow-up, the patch to files/opentracker.in is unnecessary and also incomplete, but we can ignore it since dougb@ already fixed it. Thanks. -- Sahil Tandon <sahil@FreeBSD.org>
State Changed From-To: open->feedback Ask maintainer to approve latest patch.
sahil 2010-04-15 21:46:50 UTC FreeBSD ports repository Modified files: net/opentracker Makefile Log: - Update MASTER_SITES - Use ${PORTNAME} variable where possible PR: ports/145637 Submitted by: Glen Barber <glen.j.barber@gmail.com> Approved by: Chris Rees (maintainer), wxs (mentor) Revision Changes Path 1.3 +3 -3 ports/net/opentracker/Makefile _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
State Changed From-To: feedback->closed Committed. Thanks!