Bug 145798 - textproc/tkdiff Makefile does not use default tcl/tk version by USE_TK=yes
Summary: textproc/tkdiff Makefile does not use default tcl/tk version by USE_TK=yes
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Kevin Lo
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-04-18 05:30 UTC by Robert Jenssen
Modified: 2010-04-19 04:20 UTC (History)
0 users

See Also:


Attachments
file.diff (530 bytes, patch)
2010-04-18 05:30 UTC, Robert Jenssen
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Robert Jenssen 2010-04-18 05:30:01 UTC
The devel/ports Makefile is hardwired to tcl/tk version 8.4 rather than using the default tcl/tk version defined in bsd.tcl.mk.

Fix: Apply attached patch:
--- textproc/tkdiff/Makefile.old	2010-04-18 12:53:30.000000000 +1000
+++ textproc/tkdiff/Makefile	2010-04-18 12:54:01.000000000 +1000
@@ -14,14 +14,14 @@
 MAINTAINER=	kevlo@FreeBSD.org
 COMMENT=	A Tk frontend for diff(1)
 
-RUN_DEPENDS=	wish8.4:${PORTSDIR}/x11-toolkits/tk84
+USE_TK=		yes
 
 NO_BUILD=	yes
 
 PLIST_FILES=	bin/tkdiff
 
 post-patch:
-	@${REINPLACE_CMD} -e 's|wish|wish8.4|' ${WRKSRC}/tkdiff
+	@${REINPLACE_CMD} -e 's|wish|${WISH}|' ${WRKSRC}/tkdiff
 
 do-install:
 	@${INSTALL_SCRIPT} ${WRKSRC}/tkdiff ${PREFIX}/bin


Patch attached with submission follows:
How-To-Repeat: cd /usr/ports/textproc/tkdiff && make
Comment 1 Mark Linimon freebsd_committer freebsd_triage 2010-04-18 09:03:12 UTC
Responsible Changed
From-To: freebsd-ports-bugs->kevlo

Fix synopsis and assign.
Comment 2 dfilter service freebsd_committer freebsd_triage 2010-04-19 04:19:53 UTC
kevlo       2010-04-19 03:19:44 UTC

  FreeBSD ports repository

  Modified files:
    textproc/tkdiff      Makefile 
  Log:
  Use default tcl/tk version by USE_TK=yes
  
  PR:     ports/145798
  Submitted by:   Robert Jenssen <robertjenssen at ozemail dot com dot au>
  
  Revision  Changes    Path
  1.14      +3 -3      ports/textproc/tkdiff/Makefile
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 3 Kevin Lo freebsd_committer freebsd_triage 2010-04-19 04:20:03 UTC
State Changed
From-To: open->closed

Committed, thanks.