Bug 146015 - multimedia/dvdrip fails to locate fping, making cluster mode unusable
Summary: multimedia/dvdrip fails to locate fping, making cluster mode unusable
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Sylvio Cesar Teixeira
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-04-24 16:40 UTC by Pascal Stumpf
Modified: 2010-04-25 14:50 UTC (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pascal Stumpf 2010-04-24 16:40:02 UTC 
The program dvdrip-master (needed to run dvdrip in cluster mode) fail to locate fping in /usr/local/sbin (it only looks in /usr/bin and /usr/sbin) and thus fails to start. The problem is in the perl package Video::DVDRip::Cluster::Master in the function check_prerequisites. Apparently, someone did not take portability very important. :/

Fix: 

-    foreach my $path ( "/usr/bin", "/usr/sbin" ) {
+    foreach my $path ( "/usr/bin", "/usr/sbin", "/usr/local/sbin" ) {
         if ( -f "$path/fping" and -x "$path/fping" ) {
             $FPING = "$path/fping";
             last;--3L3ljwBBDtWEockokpw2om7IBXTIuPtQXs2K7A62ca2OYLZB
Content-Type: text/plain; name="file.diff"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment; filename="file.diff"

--- Master.pm.orig      2010-04-24 17:24:44.993423292 +0200
+++ Master.pm   2010-04-24 17:25:52.201580088 +0200
@@ -122,7 +122,7 @@
 sub check_prerequisites {
     my $class = shift;
Comment 1 Mark Linimon freebsd_committer freebsd_triage 2010-04-24 17:29:10 UTC 
Responsible Changed
From-To: freebsd-bugs->freebsd-ports-bugs

ports PR.
Comment 2 Sylvio Cesar Teixeira freebsd_committer freebsd_triage 2010-04-24 19:06:50 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->sylvio

I'll take it.
Comment 3 dfilter service freebsd_committer freebsd_triage 2010-04-25 14:47:48 UTC 
sylvio      2010-04-25 13:47:39 UTC

  FreeBSD ports repository

  Modified files:
    multimedia/dvdrip    Makefile 
  Added files:
    multimedia/dvdrip/files 
                            patch-lib__Video__DVDRip__Cluster__Master.pm 
  Log:
  - Fix problem in cluster mode
  - BUMP PORTREVISION
  
  PR:             ports/146015
  Submitted by:   Pascal Stumpf <pascal.stumpf@cubes.de>
  
  Revision  Changes    Path
  1.47      +1 -1      ports/multimedia/dvdrip/Makefile
  1.1       +11 -0     ports/multimedia/dvdrip/files/patch-lib__Video__DVDRip__Cluster__Master.pm (new)
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 4 Sylvio Cesar Teixeira freebsd_committer freebsd_triage 2010-04-25 14:47:57 UTC 
State Changed
From-To: open->closed

Committed. Thanks!