Updates for the net/freeswitch rc.d script Fix: Apply the following patch, then test 6 and 7 above. How-To-Repeat: There are numerous problems with this script, some more serious than others. The issue that brought it to my attention is the "KEYWORD: FreeBSD" that needs to be removed as that has not been necessary for years now, and I don't want the example perpetuated. Please see http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/rc-scripts.html for more information. Other changes: 1. Add a $FreeBSD$ CVS Id 2. Add KEYWORD: shutdown since this script seems to start a persistent service which should be shut down cleanly when the system is shut down. 3. Move the default value assignments down after load_rc_config. This is particularly important for _pidfile which would not have actually picked up the value from rc.conf. 4. Remove the return statements from the ends of the functions, since that's what will happen anyway. 5. Remove a bunch of trailing whitespace These two need testing: 6. The _restart method is probably not needed, since it is a duplicate of the same procedure from rc.subr. 7. In the _start method $command_args doesn't seem to be taken into account because the script is not using the method from rc.subr.
Responsible Changed From-To: freebsd-ports-bugs->dougb Submitter has GNATS access (via the GNATS Auto Assign Tool)
Maintainer of net/freeswitch, Please note that PR ports/146442 has just been submitted. If it contains a patch for an upgrade, an enhancement or a bug fix you agree on, reply to this email stating that you approve the patch and a committer will take care of it. The full text of the PR can be found at: http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/146442 -- Edwin Groothuis via the GNATS Auto Assign Tool edwin@FreeBSD.org
State Changed From-To: open->feedback Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
State Changed From-To: feedback->open Past maintainer timeout
Responsible Changed From-To: dougb->jpaetzel Other freeswitch PRs are assigned to you, so I'm assuming you have an interest.
dougb 2010-08-11 05:22:11 UTC FreeBSD ports repository Modified files: net/freeswitch-core Makefile net/freeswitch-core/files freeswitch.in Log: 1. It's generally preferred that ports rc.d files use REQUIRE: LOGIN unless there is a good reason not to. However this service runs as an unprivileged user, which makes that a requirement. 2. The default variable assignments have to come after load_rc_config to be effective. 3. _flags should not be reproduced in command_args 4. The start and restart methods were superfluous, instead use wait_for_pids in the _stop method. Bump PORTREVISION PR: ports/146442 Submitted by: me Approved by: maintainer Revision Changes Path 1.9 +1 -1 ports/net/freeswitch-core/Makefile 1.4 +10 -38 ports/net/freeswitch-core/files/freeswitch.in _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
State Changed From-To: open->closed A better version based on the latest version of the port was committed as CVS version 1.4.
Responsible Changed From-To: jpaetzel->dougb My problem, my resolution. :)