math/dieharder is marked BROKEN on i386, amd64 and sparc64. It shouldn't compile on any platform except amd64 because it uses amd64 assembler unconditionally in libdieharder/skein_block_ref.c. The attached patch simply comments out the affected function, as it does not seem to be used at all (dieharder compiles and runs fine without it)! This was tested on i386 by me. Could somebody please test if dieharder compiles also on ia64 and sparc64 and, if it works, remove the BROKEN tag from the Makefile? Fix: Put the attached file into math/dieharder/files/patch-libdieharder__skein_block_ref.c and remove the BROKEN mark from math/dieharder/Makefile Patch attached with submission follows: How-To-Repeat: cd /usr/ports/math/dieharder && make (on non-amd64)
Maintainer of math/dieharder, Please note that PR ports/146579 has just been submitted. If it contains a patch for an upgrade, an enhancement or a bug fix you agree on, reply to this email stating that you approve the patch and a committer will take care of it. The full text of the PR can be found at: http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/146579 -- Edwin Groothuis via the GNATS Auto Assign Tool edwin@FreeBSD.org
State Changed From-To: open->feedback Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
On Fri, 14 May 2010 12:30:13 UT, Edwin Groothuis <edwin@freebsd.org> wrote: > Maintainer of math/dieharder, > > Please note that PR ports/146579 has just been submitted. > > If it contains a patch for an upgrade, an enhancement or a bug fix > you agree on, reply to this email stating that you approve the patch > and a committer will take care of it. > > The full text of the PR can be found at: > http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/146579 > > -- > Edwin Groothuis via the GNATS Auto Assign Tool > edwin@FreeBSD.org > The non-portable time() function in libdieharder/skein_block_ref.c was copied from libdieharder/bauer/skein_block_ref.c, where is used to time a skein block test. I'm not sure why it wasn't trimmed from libdieharder/skein_block_ref.c, as the other time() calls in the sources evidently use time(3). I'll disable the problematic function, although slightly differently, and also make a number of other small changes. Please apply the attached patch to the port, instead of the original submission. I've removed the architectural restrictions: earlier versions of the port were known to work with Debian on ia64 and sparc, so let's see if the current version works on these architectures with FreeBSD. We can restore the restrictions or apply additional patches later if it does not. b.
State Changed From-To: feedback->closed Committed. Thanks!
miwi 2010-06-05 19:40:22 UTC FreeBSD ports repository Modified files: math/dieharder Makefile Added files: math/dieharder/files patch-libdieharder__skein_block_ref.c Log: - Unbreak && Fix build PR: 146579 Submitted by: Lucius Windschuh <lwindschuh@gmail.com> Approved by: bf@ (maintainer) Revision Changes Path 1.11 +3 -5 ports/math/dieharder/Makefile 1.1 +16 -0 ports/math/dieharder/files/patch-libdieharder__skein_block_ref.c (new) _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"