Bug 146752 - [patch] emulators/virtualbox-ose: VirtualBox assertion: Lock/Unlock is not implemented
Summary: [patch] emulators/virtualbox-ose: VirtualBox assertion: Lock/Unlock is not im...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Virtualbox Team (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-20 11:50 UTC by Mike Makonnen
Modified: 2010-06-07 17:40 UTC (History)
0 users

See Also:


Attachments
file.diff (436 bytes, patch)
2010-05-20 11:50 UTC, Mike Makonnen
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mike Makonnen freebsd_committer freebsd_triage 2010-05-20 11:50:00 UTC
When trying to install Windows XP SP2 as a guest OS from the hosts DVD drive the following assertion is triggered right after the setup program finishes loading drivers: Lock/Unlock is not implemented.  I noticed this after the recent upgrade to VirtualBox 3.1.8.  I also did a world and kernel upgrade in the mean time so I'm not sure if that may have had something to do with it. The Host is a 9-Current amd64 box.

Fix: The problem is a missing compile time #define that makes it think FreeBSD doesn't support locking of the DVD drive door. The attached patch fixes the problem for me.

Patch attached with submission follows:
How-To-Repeat: Try to install Windows XP as a guest OS from a DVD Drive.
Comment 1 Mark Linimon freebsd_committer freebsd_triage 2010-05-20 16:42:14 UTC
Responsible Changed
From-To: freebsd-ports-bugs->vbox

Over to maintainer(s).
Comment 2 Beat Gaetzi freebsd_committer freebsd_triage 2010-05-25 12:50:18 UTC
Hi,

Thanks for this patch. I've added the patch to our development repository:
http://svn.bluelife.at/index.cgi/blueports/revision/?rev=842

The patch will be included in the upcoming 3.2.0 update.

Regards,
Beat
Comment 3 dfilter service freebsd_committer freebsd_triage 2010-06-07 17:32:14 UTC
beat        2010-06-07 16:31:58 UTC

  FreeBSD ports repository

  Modified files:
    emulators/virtualbox-ose Makefile distinfo pkg-plist 
    emulators/virtualbox-ose/files patch-configure 
                                   patch-src-VBox-Devices-Makefile.kmk 
                                   patch-src-VBox-HostDrivers-Makefile.kmk 
  Added files:
    emulators/virtualbox-ose/files 
                                   patch-src-VBox-Devices-Storage-DrvHostDVD.cpp 
                                   patch-src-VBox-Frontends-Makefile.kmk 
                                   patch-src-VBox-Frontends-VirtualBox-src-settings-vm-VBoxVMSettingsHD.h 
  Removed files:
    emulators/virtualbox-ose/files patch-include-iprt-file.h 
                                   patch-src-VBox-Additions-common-VBoxService-VBoxService.cpp 
                                   patch-src-VBox-Devices-Audio-audio.c 
                                   patch-src-VBox-Frontends-VBoxManage-VBoxInternalManage.cpp 
                                   patch-src-VBox-Frontends-VBoxManage-VBoxManageHelp.cpp 
                                   patch-src-VBox-Frontends-VBoxManage-VBoxManageModifyVM.cpp 
                                   patch-src-VBox-Main-AudioAdapterImpl.cpp 
                                   patch-src-VBox-Main-ConsoleImpl.cpp 
                                   patch-src-VBox-Main-ConsoleImpl2.cpp 
                                   patch-src-VBox-Main-include-ConsoleImpl.h 
                                   patch-src-VBox-Runtime-r3-posix-fileio-posix.cpp 
                                   patch-src-settings-vm-VBoxVMSettingsAudio.cpp 
                                   pkg-install.in 
  Log:
  - Update to 3.2.2
  - Update guest additions to 3.2.2.
  - Add option to build with VNC support (Disabled by default)
  - Add option to build with VDE support (Disabled by default) [1]
  - Add option to build webservice (Disabled by default) [2]
  - Fix build with QT4 support disabled and X11 support enabled. [3]
  - Fix build with X11 support disabled. [4]
  - Replace custom pkg-install.in script with GROUPS framework.
  - Do not build Guest Additions in virtualbox-ose port.
  - Implement locking/unlocking of host DVD drive. [5]
  - Add LICENSE and LICENSE_FILE.
  
  PR:             ports/146752 [5]
  Submitted by:   mtm@ [5]
  Requested by:   Mario Lobo <lobo AT bsd.com.br> [1],
                  Hubert Tournier <hubert AT frbsd.org> [2]
  Reported by:    Emil Mikulic <emil AT dmr.ath.cx> [3], mm@ [4]
  
  Many thanks to the VirtualBox developers (especially Alexander Eichner
  for all his work and help), all tester and patch submitter and the whole
  vbox@ team especially decke@.
  
  Revision  Changes    Path
  1.23      +45 -13    ports/emulators/virtualbox-ose/Makefile
  1.11      +6 -6      ports/emulators/virtualbox-ose/distinfo
  1.6       +2 -48     ports/emulators/virtualbox-ose/files/patch-configure
  1.2       +0 -13     ports/emulators/virtualbox-ose/files/patch-include-iprt-file.h (dead)
  1.2       +0 -12     ports/emulators/virtualbox-ose/files/patch-src-VBox-Additions-common-VBoxService-VBoxService.cpp (dead)
  1.2       +0 -14     ports/emulators/virtualbox-ose/files/patch-src-VBox-Devices-Audio-audio.c (dead)
  1.5       +0 -11     ports/emulators/virtualbox-ose/files/patch-src-VBox-Devices-Makefile.kmk
  1.1       +14 -0     ports/emulators/virtualbox-ose/files/patch-src-VBox-Devices-Storage-DrvHostDVD.cpp (new)
  1.1       +18 -0     ports/emulators/virtualbox-ose/files/patch-src-VBox-Frontends-Makefile.kmk (new)
  1.3       +0 -50     ports/emulators/virtualbox-ose/files/patch-src-VBox-Frontends-VBoxManage-VBoxInternalManage.cpp (dead)
  1.2       +0 -37     ports/emulators/virtualbox-ose/files/patch-src-VBox-Frontends-VBoxManage-VBoxManageHelp.cpp (dead)
  1.2       +0 -23     ports/emulators/virtualbox-ose/files/patch-src-VBox-Frontends-VBoxManage-VBoxManageModifyVM.cpp (dead)
  1.1       +11 -0     ports/emulators/virtualbox-ose/files/patch-src-VBox-Frontends-VirtualBox-src-settings-vm-VBoxVMSettingsHD.h (new)
  1.2       +3 -3      ports/emulators/virtualbox-ose/files/patch-src-VBox-HostDrivers-Makefile.kmk
  1.2       +0 -14     ports/emulators/virtualbox-ose/files/patch-src-VBox-Main-AudioAdapterImpl.cpp (dead)
  1.2       +0 -11     ports/emulators/virtualbox-ose/files/patch-src-VBox-Main-ConsoleImpl.cpp (dead)
  1.2       +0 -103    ports/emulators/virtualbox-ose/files/patch-src-VBox-Main-ConsoleImpl2.cpp (dead)
  1.3       +0 -20     ports/emulators/virtualbox-ose/files/patch-src-VBox-Main-include-ConsoleImpl.h (dead)
  1.2       +0 -16     ports/emulators/virtualbox-ose/files/patch-src-VBox-Runtime-r3-posix-fileio-posix.cpp (dead)
  1.2       +0 -12     ports/emulators/virtualbox-ose/files/patch-src-settings-vm-VBoxVMSettingsAudio.cpp (dead)
  1.3       +0 -22     ports/emulators/virtualbox-ose/files/pkg-install.in (dead)
  1.14      +12 -1     ports/emulators/virtualbox-ose/pkg-plist
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 4 Beat Gaetzi freebsd_committer freebsd_triage 2010-06-07 17:34:36 UTC
State Changed
From-To: open->closed

Committed. Thanks!