Fix: Mimic bsd.port.mk behavior. This should depend on whether ${STRIP} has `-s', though. Even better would be to strip binaries by install(1), e.g. by using BSD_INSTALL_PROGRAM.
Responsible Changed From-To: freebsd-ports-bugs->wxs Over to maintainer (via the GNATS Auto Assign Tool)
State Changed From-To: open->closed Committed. Thanks!
Hmm, it's better to use same check as in ports/150689. WITH_DEBUG is for things like -DDEBUG, i.e. compile-time optimization that hurts performance while debug symbols usually do not. --- a.diff begins here --- Index: devel/git/Makefile =================================================================== RCS file: /a/.cvsup/ports/devel/git/Makefile,v retrieving revision 1.94 diff -u -p -r1.94 Makefile --- devel/git/Makefile 23 Oct 2010 15:07:55 -0000 1.94 +++ devel/git/Makefile 26 Oct 2010 19:32:27 -0000 @@ -195,7 +195,7 @@ OPTIONS= GUI "Enable building of GUI too .include <bsd.port.options.mk> -.ifndef (WITH_DEBUG) +.ifdef (STRIP) && ${STRIP} != "" ALL_TARGET= all strip .endif --- a.diff ends here ---