audio/icecast2 offers a config reload by sending it a SIGHUP like most daemons do. However the rc script doesn't have the reload command. Fix: If I understand the rcng stuff right, it should be enough to just add the extra command reload, everything else is covered by defaults. This simple patch should do the job: How-To-Repeat: Install port audio/icecast2 and run the rc script: /usr/local/etc/rc.d/icecast2 Usage: /usr/local/etc/rc.d/icecast2 [fast|force|one](start|stop|restart|rcvar|status|poll) No reload there.
Maintainer of audio/icecast2, Please note that PR ports/147921 has just been submitted. If it contains a patch for an upgrade, an enhancement or a bug fix you agree on, reply to this email stating that you approve the patch and a committer will take care of it. The full text of the PR can be found at: http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/147921 -- Edwin Groothuis via the GNATS Auto Assign Tool edwin@FreeBSD.org
State Changed From-To: open->feedback Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
This patch is okay. By the way, I would like to add a blank line before "extra_commands". Thanks. Sunpoet
State Changed From-To: feedback->open Maintainer approved but suggested one cosmetic change.
Responsible Changed From-To: freebsd-ports-bugs->ohauer I take it
ohauer 2010-08-16 15:23:57 UTC FreeBSD ports repository Modified files: audio/icecast2 Makefile audio/icecast2/files icecast2.sh.in Log: - add reload command to rc script - connect to license framework PR: 147921 Submitted by: Ralf Gebhart <gebhart _at_ secnetix.de> Reviewed by: maintainer, glarkin (mentor) Revision Changes Path 1.67 +3 -1 ports/audio/icecast2/Makefile 1.8 +2 -1 ports/audio/icecast2/files/icecast2.sh.in _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
State Changed From-To: open->closed Committed, thank you! Approved by: glarkin (mentor)