If I enable the following line in port security/pulledpork LICENSE= GPLv2 Install fails with the following error message sed: 1: "s!%%share/licenses/pull ...": unescaped newline inside substitute pattern see the last lines from the build log (make -d A) Please enlighten me what goes wrong here. How-To-Repeat: Apply patch from PR 148247 to the port remove the comment before LICENSE= GPLv2 make install
Responsible Changed From-To: freebsd-ports-bugs->glarkin I'll take it
I think it may be due to using PLIST_DIR inside SUB_LIST. --- a.diff begins here --- Index: security/pulledpork/Makefile =================================================================== RCS file: /a/.cvsup/ports/security/pulledpork/Makefile,v retrieving revision 1.3 diff -u -p -r1.3 Makefile --- security/pulledpork/Makefile 2 Jul 2010 19:49:44 -0000 1.3 +++ security/pulledpork/Makefile 23 Jul 2010 23:24:34 -0000 @@ -17,21 +17,21 @@ COMMENT= Script to update snort-2.8+ rul RUN_DEPENDS= ${SITE_PERL}/LWP/Simple.pm:${PORTSDIR}/www/p5-libwww \ p5-Crypt-SSLeay>=0.57:${PORTSDIR}/security/p5-Crypt-SSLeay -#LICENSE= GPLv2 +LICENSE= GPLv2 +# collides with _LICENSE_REPORT, cf. ports/148808 +#LICENSE_FILE= ${WRKSRC}/LICENSE NO_BUILD= yes USE_PERL5_RUN= yes -PLIST_DIRS= etc/pulledpork +PLIST_DIRS= %%ETCDIR%% PLIST_FILES= bin/pulledpork.pl \ - ${PLIST_DIRS}/disablesid.conf.sample \ - ${PLIST_DIRS}/dropsid.conf.sample \ - ${PLIST_DIRS}/enablesid.conf.sample \ - ${PLIST_DIRS}/pulledpork.conf.sample + %%ETCDIR%%/disablesid.conf.sample \ + %%ETCDIR%%/dropsid.conf.sample \ + %%ETCDIR%%/enablesid.conf.sample \ + %%ETCDIR%%/pulledpork.conf.sample -CONFIG_DIR= ${PREFIX}/${PLIST_DIRS} SUB_FILES= pkg-message -SUB_LIST= CONFIGDIR=${CONFIG_DIR} .include <bsd.port.pre.mk> @@ -53,12 +53,12 @@ post-patch: do-install: ${INSTALL_SCRIPT} ${WRKSRC}/pulledpork.pl ${PREFIX}/bin - @${MKDIR} -m 750 ${CONFIG_DIR} + @${MKDIR} -m 750 ${ETCDIR} # pulledpork.conf contains the snort user registration key, do not install world readable - ${INSTALL_DATA} -m 440 ${WRKSRC}/etc/pulledpork.conf ${CONFIG_DIR}/pulledpork.conf.sample - ${INSTALL_DATA} ${WRKSRC}/etc/disablesid.conf ${CONFIG_DIR}/disablesid.conf.sample - ${INSTALL_DATA} ${WRKSRC}/etc/dropsid.conf ${CONFIG_DIR}/dropsid.conf.sample - ${INSTALL_DATA} ${WRKSRC}/etc/enablesid.conf ${CONFIG_DIR}/enablesid.conf.sample + ${INSTALL_DATA} -m 440 ${WRKSRC}/etc/pulledpork.conf ${ETCDIR}/pulledpork.conf.sample + ${INSTALL_DATA} ${WRKSRC}/etc/disablesid.conf ${ETCDIR}/disablesid.conf.sample + ${INSTALL_DATA} ${WRKSRC}/etc/dropsid.conf ${ETCDIR}/dropsid.conf.sample + ${INSTALL_DATA} ${WRKSRC}/etc/enablesid.conf ${ETCDIR}/enablesid.conf.sample .if !defined(NOPORTDOCS) @${MKDIR} ${DOCSDIR} Index: security/pulledpork/files/pkg-message.in =================================================================== RCS file: /a/.cvsup/ports/security/pulledpork/files/pkg-message.in,v retrieving revision 1.1 diff -u -p -r1.1 pkg-message.in --- security/pulledpork/files/pkg-message.in 10 May 2010 02:53:35 -0000 1.1 +++ security/pulledpork/files/pkg-message.in 23 Jul 2010 23:17:22 -0000 @@ -1,7 +1,7 @@ ===================================================================== In order to use pulled pork, adjust the config files located in -%%CONFIGDIR%%/ +%%ETCDIR%%/ Important Note: --- a.diff ends here ---
> I think it may be due to using PLIST_DIR inside SUB_LIST. Thanks, your patch fix the issue if the license framework is enabled. I guess there are many other ports which have the same problem. Please close the PR. -- olli
Responsible Changed From-To: glarkin->ohauer Reassigned to Olli, since he has commit privs now.
State Changed From-To: open->analyzed changed to -> analyzed
ohauer 2010-08-03 19:16:35 UTC FreeBSD ports repository Modified files: security/pulledpork Makefile Log: - force commit PR ports/148267 PR: ports/148267 Approved by: glarkin (mentor) Revision Changes Path 1.5 +0 -0 ports/security/pulledpork/Makefile _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
State Changed From-To: analyzed->closed Committed