Bug 148269 - [PATCH] sysutils/ipmitool: Code cleanup found when building
Summary: [PATCH] sysutils/ipmitool: Code cleanup found when building
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Greg Larkin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-07-01 01:20 UTC by Sean Bruno
Modified: 2010-07-28 15:10 UTC (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sean Bruno freebsd_committer freebsd_triage 2010-07-01 01:20:08 UTC 
This patch cleans up some of the C code in the ipmiport and a really ugly file filled with ^M meta characters.  Should be applied.  This will allow ipmitools to compile on legacy (4.X) BSD cleanly.

Fix: 

Apply patch from with patch -p0 < ipmi.diff

The patch file was too big, so please grab it from:

http://people.freebsd.org/~sbruno/ipmi.diff
How-To-Repeat: Attempt to build on non-supported, 4.X machines.
Comment 1 Greg Larkin freebsd_committer freebsd_triage 2010-07-23 19:58:20 UTC 
State Changed
From-To: open->analyzed

Hi Sean, 

Can you fetch http://people.freebsd.org/~glarkin/diffs/sysutils-ipmitool.diff 
and apply it to the current CVS version of the sysutils/ipmitool port? 

There is a DOS2UNIX variable in the ports infrastructure, so I removed 
the giant patch that deletes the ^M characters and used DOS2UNIX to do 
the conversion instead. 

Do these changes build on supported OS versions, or do the patches need to 
be conditionalized? 

Thank you, 
Greg
Comment 2 Greg Larkin freebsd_committer freebsd_triage 2010-07-23 19:58:20 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->glarkin
Comment 3 seanbru 2010-07-23 20:51:08 UTC 
The patch is not conditional.  The patch you suggested does work for me
on the couple of environments at my disposal.

Commit fire!

Sean
Comment 4 Greg Larkin freebsd_committer freebsd_triage 2010-07-23 21:44:22 UTC 
State Changed
From-To: analyzed->feedback

Tinderbox builds succeeded with revised patch, and FreeBSD 4.x 
build succeeded.  Now awaiting maintainer approval before committing.
Comment 5 dfilter service freebsd_committer freebsd_triage 2010-07-28 15:04:34 UTC 
glarkin     2010-07-28 14:04:21 UTC

  FreeBSD ports repository

  Modified files:
    sysutils/ipmitool    Makefile 
  Added files:
    sysutils/ipmitool/files patch-include__ipmitool__ipmi_sdr.h 
                            patch-lib__ipmi_fru.c 
                            patch-lib__ipmi_sdr.c 
                            patch-src__ipmishell.c 
                            patch-src__plugins__lan__lan.c 
  Log:
  - Patch the code to enable clean compiling on legacy (4.x) BSD systems.
  
  PR:             ports/148269
  Submitted by:   sbruno
  Approved by:    Steve Polyack <spolyack at collaborativefusion dot com> (maintainer)
  
  Revision  Changes    Path
  1.19      +2 -2      ports/sysutils/ipmitool/Makefile
  1.1       +11 -0     ports/sysutils/ipmitool/files/patch-include__ipmitool__ipmi_sdr.h (new)
  1.1       +21 -0     ports/sysutils/ipmitool/files/patch-lib__ipmi_fru.c (new)
  1.1       +83 -0     ports/sysutils/ipmitool/files/patch-lib__ipmi_sdr.c (new)
  1.1       +10 -0     ports/sysutils/ipmitool/files/patch-src__ipmishell.c (new)
  1.1       +10 -0     ports/sysutils/ipmitool/files/patch-src__plugins__lan__lan.c (new)
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 6 Greg Larkin freebsd_committer freebsd_triage 2010-07-28 15:04:36 UTC 
State Changed
From-To: feedback->closed

Committed, thank you!