The port currently doesn't bring in dmidecode as a dependency which is necessary for the virtualization facts: is_virtual and virtual to report useful values.
Maintainer of sysutils/facter, Please note that PR ports/148391 has just been submitted. If it contains a patch for an upgrade, an enhancement or a bug fix you agree on, reply to this email stating that you approve the patch and a committer will take care of it. The full text of the PR can be found at: http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/148391 -- Edwin Groothuis via the GNATS Auto Assign Tool edwin@FreeBSD.org
State Changed From-To: open->feedback Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Responsible Changed From-To: freebsd-ports-bugs->sahil I'll take it.
On 07/05/2010 03:19 PM, Sahil Tandon wrote: > On Mon, 2010-07-05 at 13:49:59 -0700, Russell Jackson wrote: > >> +RUN_DEPENDS= /usr/local/sbin/dmidecode:${PORTSDIR}/sysutils/dmidecode > > Please do not hard-code 'usr/local'; instead, use ${LOCALBASE}. > Whoops. Sorry about that. Hung over from 4th of July :-(. -- Russell A Jackson <raj@csub.edu> Network Analyst California State University, Bakersfield
On Mon, 2010-07-05 at 13:49:59 -0700, Russell Jackson wrote: > +RUN_DEPENDS= /usr/local/sbin/dmidecode:${PORTSDIR}/sysutils/dmidecode Please do not hard-code 'usr/local'; instead, use ${LOCALBASE}. -- Sahil Tandon <sahil@FreeBSD.org>
On 07/05/2010 03:19 PM, Sahil Tandon wrote: > On Mon, 2010-07-05 at 13:49:59 -0700, Russell Jackson wrote: > >> +RUN_DEPENDS= /usr/local/sbin/dmidecode:${PORTSDIR}/sysutils/dmidecode > > Please do not hard-code 'usr/local'; instead, use ${LOCALBASE}. > Do I need to resubmit the patch, or will the committer fix it? -- Russell A. Jackson <raj@csub.edu> Network Analyst California State University, Bakersfield
On Mon, 2010-07-05 at 17:49:17 -0700, Russell Jackson wrote: > On 07/05/2010 03:19 PM, Sahil Tandon wrote: > >On Mon, 2010-07-05 at 13:49:59 -0700, Russell Jackson wrote: > > > >>+RUN_DEPENDS= /usr/local/sbin/dmidecode:${PORTSDIR}/sysutils/dmidecode > > > >Please do not hard-code 'usr/local'; instead, use ${LOCALBASE}. > > Do I need to resubmit the patch, or will the committer fix it? I can fix it if/when the maintainer approves your patch in principle. -- Sahil Tandon <sahil@FreeBSD.org>
sahil 2010-07-22 03:18:16 UTC FreeBSD ports repository Modified files: sysutils/facter Makefile Log: - RUN_DEPENDS on sysutils/dmidecode - Bump PORTREVISION PR: ports/148391 Submitted by: Russell Jackson <raj@csub.edu> Approved by: maintainer timeout (> 14 days) Revision Changes Path 1.10 +3 -0 ports/sysutils/facter/Makefile _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
State Changed From-To: feedback->closed Committed, with minor changes. Thanks!