Update to 1.53: - post-patch target updated (to make use of 'xz' instead of 'lzcat', see PR148604)
Responsible Changed From-To: freebsd-ports-bugs->clsung Over to maintainer (via the GNATS Auto Assign Tool)
Frederic Culot <frederic@culot.org> writes: > post-patch: .SILENT > - ${REINPLACE_CMD} 's/lzcat/xz/' ${WRKSRC}/configure > + ${REINPLACE_CMD} 's/=lzcat/=xz/' ${WRKSRC}/configure > + ${REINPLACE_CMD} 's/lzcat//' ${WRKSRC}/configure Please, don't use REINPLACE_CMD several times against same file. It makes harder to view changes $ cd $(make -V WRKSRC) $ diff -up configure.bak configure Besides, I think new version already distinguishes between XZ and LZCAT. It's better to patch the source. post-patch: .SILENT ${REINPLACE_CMD} '/\.xz/ { N; s/dcLzma/dcXz/; }' ${WRKSRC}/diffstat.c So, it'll look like @@ -1934,7 +1934,7 @@ is_compressed(const char *name) } else if (len > 5 && !strcmp(name + len - 5, ".lzma")) { which = dcLzma; } else if (len > 3 && !strcmp(name + len - 3, ".xz")) { - which = dcLzma; + which = dcXz; } else { which = dcNone; }
Following an email exchange with swell.k at gmail.com, I send an updated patch with the post-patch Makefile target applying on configure replaced by a patch applying on the source and contained in files/patch-diffstat.c. Many thanks to swell.k for his advise. Frederic
State Changed From-To: open->closed Committed. Thank You.
clsung 2010-09-06 02:21:18 UTC FreeBSD ports repository Modified files: textproc/diffstat Makefile distinfo Added files: textproc/diffstat/files patch-diffstat.c Log: - Update to 1.53 PR: ports/149500 Submitted by: Frederic Culot <frederic_AT_culot dot org> Reviewed by: swell.k at gmail.com Revision Changes Path 1.32 +1 -5 ports/textproc/diffstat/Makefile 1.22 +3 -3 ports/textproc/diffstat/distinfo 1.1 +11 -0 ports/textproc/diffstat/files/patch-diffstat.c (new) _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"