Bug 149561 - mail/p5-Mail-SpamAssassin Test suite fails with perl 5.12.0
Summary: mail/p5-Mail-SpamAssassin Test suite fails with perl 5.12.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Martin Matuska
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-08-12 10:10 UTC by takefu
Modified: 2010-10-06 11:58 UTC (History)
0 users

See Also:


Attachments
p5-Mail-SpamAssassin.diff (10.29 KB, patch)
2010-08-12 10:10 UTC, takefu
no flags Details | Diff
patch-bug6392 (8.28 KB, text/plain)
2010-09-20 13:57 UTC, Martin Matuska
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description takefu 2010-08-12 10:10:01 UTC
lang/perl5.12 problems occur in combination.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6392
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2010-08-12 11:02:24 UTC
Maintainer of mail/p5-Mail-SpamAssassin,

Please note that PR ports/149561 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/149561

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2010-08-12 11:02:27 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 3 Edwin Groothuis freebsd_committer freebsd_triage 2010-08-12 12:28:54 UTC
Maintainer of mail/p5-Mail-SpamAssassin,

Please note that PR ports/149561 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/149561

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 4 Michael Scheidell 2010-08-12 14:51:37 UTC
call secnap's 'philly office' if you need me.

(215) 554-6175   extension 1259


On 8/12/10 7:28 AM, Edwin Groothuis wrote:
> Maintainer of mail/p5-Mail-SpamAssassin,
>
> Please note that PR ports/149561 has just been submitted.
>
> If it contains a patch for an upgrade, an enhancement or a bug fix
> you agree on, reply to this email stating that you approve the patch
> and a committer will take care of it.
>
> The full text of the PR can be found at:
>      http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/149561
>
>    

-- 
Michael Scheidell, CTO
o: 561-999-5000
d: 561-948-2259
ISN: 1259*1300
 > *| *SECNAP Network Security Corporation

    * Certified SNORT Integrator
    * 2008-9 Hot Company Award Winner, World Executive Alliance
    * Five-Star Partner Program 2009, VARBusiness
    * Best in Email Security,2010: Network Products Guide
    * King of Spam Filters, SC Magazine 2008

______________________________________________________________________
This email has been scanned and certified safe by SpammerTrap(r). 
For Information please see http://www.secnap.com/products/spammertrap/
______________________________________________________________________
Comment 5 Michael Scheidell 2010-08-12 21:25:44 UTC
On 8/12/10 7:28 AM, Edwin Groothuis wrote:
> Maintainer of mail/p5-Mail-SpamAssassin,
>
> Please note that PR ports/149561 has just been submitted.
>
> If it contains a patch for an upgrade, an enhancement or a bug fix
> you agree on, reply to this email stating that you approve the patch
> and a committer will take care of it.
>
> The full text of the PR can be found at:
>      http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/149561
>
>    
Thanks, see patch.  other issues with perl 5.12.* might indicate not 
supporting it yet.
SA pulls in (as dependencies), modules that perl 5.12.1 already has.  
and, the ports tree has modules that are OLDER then the stock perl 
5.12.* modules.

I am going to investigate this and the same issues with amavisd-new port.

Bug submitter: do you suggest that I make this port BROKEN with perl 
5.12.1 till this is sorted out? or just muddle alone?

-- 
Michael Scheidell, CTO
o: 561-999-5000
d: 561-948-2259
ISN: 1259*1300
 > *| *SECNAP Network Security Corporation

    * Certified SNORT Integrator
    * 2008-9 Hot Company Award Winner, World Executive Alliance
    * Five-Star Partner Program 2009, VARBusiness
    * Best in Email Security,2010: Network Products Guide
    * King of Spam Filters, SC Magazine 2008

______________________________________________________________________
This email has been scanned and certified safe by SpammerTrap(r). 
For Information please see http://www.secnap.com/products/spammertrap/
______________________________________________________________________
Comment 6 Mark Linimon freebsd_committer freebsd_triage 2010-08-13 00:32:16 UTC
State Changed
From-To: feedback->analyzed

Maintainer has replied with patch, but it may need more work.
Comment 7 Philip M. Gollucci freebsd_committer freebsd_triage 2010-09-09 19:44:04 UTC
Responsible Changed
From-To: freebsd-ports-bugs->perl

to perl
Comment 8 Martin Matuska freebsd_committer freebsd_triage 2010-09-20 13:50:10 UTC
Responsible Changed
From-To: perl->mm

This is a local port issue, taking over.
Comment 9 Martin Matuska freebsd_committer freebsd_triage 2010-09-20 13:57:02 UTC
A better approach than X patches for X files is using one patch file
with direct SVN import from Apache SVN (spamassassin/branches/3.3). On
3.3.2 update, this file just gets removed.

Apache SVN changeset: 943933
https://svn.apache.org/viewvc?view=revision&revision=943933

Maintainer, do you agree to adding of this patch?

Thanks.
Comment 10 Martin Matuska freebsd_committer freebsd_triage 2010-09-20 14:03:05 UTC
State Changed
From-To: analyzed->feedback

Awaiting feedback from maintainer.
Comment 11 Michael Scheidell 2010-09-20 14:13:42 UTC
There are action more issues with perl .12 and this includes dependencies which will pull in older perl modules from ports which will conflict with functions in .12

Safest thing for today you just don't use .12.
If someone were to setup a green fields 7.3 or 8 freebsd take out all the perl module dependencies from spam assassin makefile AND from the rest of its dependencies it might pull other proposals in then just pull in the perl modules that are required and not in .12 and submit patches to makefile i'd give them a test and see if it took care of it.  Run depends and build depends would have to look out for different versions of perl,

This is something i plan on doing soon but really was waiting for the imminent release of spam assassin 3.3.2

--
Michael Scheidell, CTO
SECNAP Network Security


-----Original message-----
From: Martin Matuska <mm@FreeBSD.org>
To: "bug-followup@FreeBSD.org" <bug-followup@FreeBSD.org>, "takefu@airport.fm" <takefu@airport.fm>, Michael Scheidell <michael.scheidell@secnap.com>
Sent: Mon, Sep 20, 2010 12:57:14 GMT+00:00
Subject: Re: ports/149561: mail/p5-Mail-SpamAssassin Test suite fails with perl 5.12.0

A better approach than X patches for X files is using one patch file
with direct SVN import from Apache SVN (spamassassin/branches/3.3). On
3.3.2 update, this file just gets removed.

Apache SVN changeset: 943933
https://svn.apache.org/viewvc?view=revision&revision=943933

Maintainer, do you agree to adding of this patch?

Thanks.
Comment 12 Martin Matuska freebsd_committer freebsd_triage 2010-09-20 15:15:18 UTC
Here is a list of directly referenced dependencies, where are the
overwriting functions?

p5-NetAddr-IP:
only in ports

p5-Archive-Tar:
5.8.9: not included
5.10.1: 1.52
5.12.2: 1.54
ports: 1.68

p5-Net-DNS:
only in ports

p5-Compress-Zlib:
5.8.9:  not included
5.10.1: 2.020
5.12.2: 2.024
ports:	2.015

p5-IO-Zlib:
5.8.9:  not included
5.10.1: 1.09
5.12.2: 1.10
ports:	1.10

p5-HTML-Parser:
only in ports

p5-IO-Compress:
5.8.9:  not included
5.10.1: 2.020
5.12.2: 2.024
ports:	2.015

p5-Test-Harness:
5.8.9:  2.64
5.10.1: 3.17
5.12.2: 3.17
ports:	3.22

p5-libwww:
only in ports

p5-Encode-Detect:
only in ports

p5-Mail-Tools:
only in ports

p5-Time-HiRes:
5.8.9:  1.9715
5.10.1: 1.9719
5.12.2: 1.9719
ports:	1.9721

p5-Mail-SPF:

p5-IO-Socket-INET6:

p5-IO-Socket-SSL:

p5-DBD-mysql:
only in ports

p5-DBD-Pg:
only in ports

p5-Digest-SHA1:
only in ports

p5-Digest-SHA:
5.8.9:  not included
5.10.1: 5.47
5.12.2: 5.47
ports:	5.48

p5-Mail-DKIM:
only in ports

p5-Crypt-OpenSSL-RSA:
only in ports

p5-IP-Country:
only in ports

The only one I can see with a lower version is p5-Compress-Zlib.
Btw. maybe p5-Time-HiRes can be omitted at all?
Comment 13 Michael Scheidell 2010-09-20 15:23:06 UTC
  They may be in dependencies for optional features.
I gave this a test before the 3.3.2 patch was finalized and ran into 
problems with newer (included in .12) pm's being overwritten by some of 
those in ports.

Options include going through every p5-* port and marking them broken or 
invalid if PERL> 5000012, or tracing down, multi-level, every dependency 
of every dependency of every dependency.

example: enable dkim, sa-compile, gnupg (needed for sa-compile), mysql, 
razor, spf, relay and dcc.
( didn't test it with pgsql).

I did not do an in depth check since at the time there was still no 
official patch in cvs for SA.

and this one is a can of worms:  it has always caused problems since it 
can include several other pm's.

  p5-Compress-Zlib.



-- 
Michael Scheidell, CTO
o: 561-999-5000
d: 561-948-2259
ISN: 1259*1300
 > *| *SECNAP Network Security Corporation

    * Certified SNORT Integrator
    * 2008-9 Hot Company Award Winner, World Executive Alliance
    * Five-Star Partner Program 2009, VARBusiness
    * Best in Email Security,2010: Network Products Guide
    * King of Spam Filters, SC Magazine 2008

______________________________________________________________________
This email has been scanned and certified safe by SpammerTrap(r). 
For Information please see http://www.secnap.com/products/spammertrap/
______________________________________________________________________
Comment 14 Martin Matuska freebsd_committer freebsd_triage 2010-09-27 23:17:19 UTC
I have cleaned up the p5-Zlib-Compress stuff and also removed
p5-Digest-SHA from this port. Can the 5.12 compat patch from upstream be
committed now?

I also suggest the following:
- do not depend on p5-Time-HiRes (this is already in all suported perl
versions)
- do not depend on p5-Test-Harness starting with Perl 5.10.1
Comment 15 dfilter service freebsd_committer freebsd_triage 2010-10-06 11:38:14 UTC
mm          2010-10-06 10:38:09 UTC

  FreeBSD ports repository

  Modified files:
    mail/p5-Mail-SpamAssassin Makefile 
  Added files:
    mail/p5-Mail-SpamAssassin/files patch-bug6392 patch-bug6396 
  Log:
  - fix unnecessary dependencies for perl >= 5.10.1
  - add upstream patch for perl 5.12 (bugs #6392, #6396)
  
  PR:             ports/150764, ports/149561
  Approved by:    maintainer (timeout in ports/150764)
  
  Revision  Changes    Path
  1.136     +17 -15    ports/mail/p5-Mail-SpamAssassin/Makefile
  1.1       +225 -0    ports/mail/p5-Mail-SpamAssassin/files/patch-bug6392 (new)
  1.1       +13 -0     ports/mail/p5-Mail-SpamAssassin/files/patch-bug6396 (new)
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 16 Martin Matuska freebsd_committer freebsd_triage 2010-10-06 11:58:53 UTC
State Changed
From-To: feedback->closed

Resolved, Thanks!