Mastertickets plugin was updated for Trac 0.12: the entire 3.0.x line supports only 0.12. And Trac in FreeBSD ports was updated to 0.12, so it is good to have the plugin that can really work with Trac 0.12 well. Fix: I had updated the port to 3.0.1 and introduced the OPTIONS knob named TRAC_11 that makes the plugin to be compiled for the Trac 0.11 if someone is not yet ready to really move to 0.12. 0.11 variant of the port still stays at 2.1.3, but the patch that allows the plugin to work with PostgreSQL backend was added. The patch is available at http://codelabs.ru/fbsd/ports/trac-mastertickets/update-to-3.0.1.diff it was tested on our Trac instance that runs 0.12 from the ports. It was also tested on the Tinderbox for 7.x/8.x/9.x and no package building problems were found. How-To-Repeat: Look at the http://github.com/coderanger/trac-mastertickets/commits/master
Responsible Changed From-To: freebsd-ports-bugs->glarkin Over to maintainer (via the GNATS Auto Assign Tool)
I had found one more issue with 0.12 version and updated the port: http://codelabs.ru/fbsd/ports/trac-mastertickets/3.0.1-fix-bad-__repr__.diff Tinderbox builds are still fine, plugin is working on our Trac 0.12 instance. Also pushed the bug upstream: http://trac-hacks.org/ticket/7607 -- Eygene _ ___ _.--. # \`.|\..----...-'` `-._.-'_.-'` # Remember that it is hard / ' ` , __.--' # to read the on-line manual )/' _/ \ `-_, / # while single-stepping the kernel. `-'" `"\_ ,_.-;_.-\_ ', fsc/as # _.-'_./ {_.' ; / # -- FreeBSD Developers handbook {_.-``-' {_/ #
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi Eygene, Thank you for your work on this port, and I have been reviewing your patch. How do you feel about omitting support for Trac 0.11? As far as I know, the rest of the Trac plugins in the ports tree simply assume Trac 0.12 is installed. Plus, this port is more complicated than most because of the different version numbers (2.1.3 for 0.11 and 3.0.1 for 0.12). I don't want to allow someone to build upstream version 2.1.3 for Trac 0.11 and install it as a port with version 3.0.1, which is what it seems to do. Would you mind submitting an updated patch that assumes 0.12 is installed? Thank you, Greg - -- Greg Larkin http://www.FreeBSD.org/ - The Power To Serve http://www.sourcehosting.net/ - Ready. Set. Code. http://twitter.com/sourcehosting/ - Follow me, follow you -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.7 (MingW32) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iD8DBQFMgW7v0sRouByUApARAmNLAKC6YNqBXKyEJu9wO6cWJO79lH8trACcCh0s 5PcAznxYySLG7CkGheSfjgI= =h0Bi -----END PGP SIGNATURE-----
Greg, good day. Fri, Sep 03, 2010 at 05:56:00PM -0400, Greg Larkin wrote: > Thank you for your work on this port, and I have been reviewing your > patch. Thanks! > How do you feel about omitting support for Trac 0.11? As far as I know, > the rest of the Trac plugins in the ports tree simply assume Trac 0.12 > is installed. I wanted to keep the 0.11 part for people who are still running 0.11: not everything is fine now with 0.12, some plugins are not ready for it and so on. I spent two days migrating our 0.11 instance to 0.12 and I should say that it is not that easy. Obviously putting a requirement for Trac >= 0.12 for the new port will prevent people who are running from upgrading mastertickets, so it will not create any confusion. > Plus, this port is more complicated than most because of the different > version numbers (2.1.3 for 0.11 and 3.0.1 for 0.12). I don't want to > allow someone to build upstream version 2.1.3 for Trac 0.11 and > install it as a port with version 3.0.1, which is what it seems to do. Yes, that is the only rough point that I see for the combined 0.11/0.12 port. > Would you mind submitting an updated patch that assumes 0.12 is > installed? I'll do, perhaps on Monday. -- Eygene _ ___ _.--. # \`.|\..----...-'` `-._.-'_.-'` # Remember that it is hard / ' ` , __.--' # to read the on-line manual )/' _/ \ `-_, / # while single-stepping the kernel. `-'" `"\_ ,_.-;_.-\_ ', fsc/as # _.-'_./ {_.' ; / # -- FreeBSD Developers handbook {_.-``-' {_/ #
Sat, Sep 04, 2010 at 09:45:30PM +0400, Eygene Ryabinkin wrote: > I'll do, perhaps on Monday. Here we go: http://codelabs.ru/fbsd/ports/trac-mastertickets/update-to-3.0.1-only-trac-0.12.diff -- Eygene _ ___ _.--. # \`.|\..----...-'` `-._.-'_.-'` # Remember that it is hard / ' ` , __.--' # to read the on-line manual )/' _/ \ `-_, / # while single-stepping the kernel. `-'" `"\_ ,_.-;_.-\_ ', fsc/as # _.-'_./ {_.' ; / # -- FreeBSD Developers handbook {_.-``-' {_/ #
glarkin 2010-09-08 22:58:18 UTC FreeBSD ports repository Modified files: www/trac-mastertickets Makefile distinfo pkg-descr Added files: www/trac-mastertickets/files patch-mastertickets__model.py Removed files: www/trac-mastertickets pkg-plist Log: - Updated to 3.0.1, which only supports Trac 0.12 [1] - Various Makefile tweaks - Incorporated one-line pkg-plist into Makefile PR: ports/150075 Submitted by: Eygene Ryabinkin <rea-fbsd at codelabs dot ru> [1] Revision Changes Path 1.11 +13 -10 ports/www/trac-mastertickets/Makefile 1.3 +3 -3 ports/www/trac-mastertickets/distinfo 1.1 +11 -0 ports/www/trac-mastertickets/files/patch-mastertickets__model.py (new) 1.2 +9 -1 ports/www/trac-mastertickets/pkg-descr 1.2 +0 -1 ports/www/trac-mastertickets/pkg-plist (dead) _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
State Changed From-To: open->closed Committed with some tweaks, thank you!