Bug 150084 - [patch] www/trac-wikinotification: allow to work with Trac 0.12
Summary: [patch] www/trac-wikinotification: allow to work with Trac 0.12
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Greg Larkin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-08-29 14:40 UTC by Eygene Ryabinkin
Modified: 2010-10-08 18:00 UTC (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eygene Ryabinkin 2010-08-29 14:40:04 UTC 
Wiki notification plugin does not work with Trac 0.12: it gives
backtrace with unknown variable error and, once this problem
is cured, spits the whole Genshi template instead of processing
conditionals within it.

Fix: 

Fix for the backtrace is in the plugin's ticket:
  http://wikinotification.ufsoft.org/ticket/100
For Genshi stuff, the template should just be updated
to the new syntax.

The patch that updates the port with those fixes is here:
  http://codelabs.ru/fbsd/ports/trac-wikinotification/0.2.1-fixes-for-Trac-0.12.diff
It was tested on our Trac 0.12 installation that was recently updated
from 0.11 -- no problems were observed.  The new port was tested
on my Tinderbox for 7.x/8.x and 9.x.
How-To-Repeat: 
Update to Trac 0.12, install the plugin and try to edit Wiki
pages.  Edits will be successful (in the sense that they will
be saved), but error message will be produced for each edit.
Mails sent by the plugin will contain the whole template with
Genshi instructions like '#if' and '#end'.
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2010-08-29 14:40:14 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->glarkin

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 dfilter service freebsd_committer freebsd_triage 2010-10-08 17:55:14 UTC 
glarkin     2010-10-08 16:55:08 UTC

  FreeBSD ports repository

  Modified files:
    www/trac-wikinotification Makefile 
  Added files:
    www/trac-wikinotification/files 
                                    patch-WikiNotification__notification.py 
                                    patch-WikiNotification__templates__wiki_notification_email_template.txt 
  Log:
  - Fixed unknown variable InternalError when used with Trac 0.12
  - Fixed formatting of wiki notification email when used with Trac 0.12
  
  PR:             ports/150084
  Submitted by:   Eygene Ryabinkin <rea-fbsd at codelabs dot ru>
  Approved by:    glarkin (maintainer)
  
  Revision  Changes    Path
  1.13      +1 -1      ports/www/trac-wikinotification/Makefile
  1.1       +72 -0     ports/www/trac-wikinotification/files/patch-WikiNotification__notification.py (new)
  1.1       +59 -0     ports/www/trac-wikinotification/files/patch-WikiNotification__templates__wiki_notification_email_template.txt (new)
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 3 Greg Larkin freebsd_committer freebsd_triage 2010-10-08 17:55:24 UTC 
State Changed
From-To: open->closed

Committed, thank you!