Bug 150432 - [FIX] x11/libcapplet does not build on OSVERSION >= 800071
Summary: [FIX] x11/libcapplet does not build on OSVERSION >= 800071
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-gnome (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-09-09 12:20 UTC by Joel Ray Holveck
Modified: 2010-12-31 18:28 UTC (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joel Ray Holveck 2010-09-09 12:20:00 UTC 
The Makefile for x11/libcapplet inhibits building if OSVERSION >= 800071; it has a conditional BROKEN= defined.  However, the solution to get it to build is pretty simple.

Fix: 

If you add -fgnu89-inline to the CFLAGS in work/libcapplet-1.4.0.5/Makefile, it'll build just fine.  I'm afraid I don't know how to have the ports Makefile conditionally patch something (we only want to add the flag if OSVERSION >= 800071), so I'm afraid I can't put a patch in this PR.
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2010-09-09 12:20:17 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->gnome

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 dfilter service freebsd_committer freebsd_triage 2010-10-02 22:04:09 UTC 
mezz        2010-10-02 21:04:04 UTC

  FreeBSD ports repository

  Modified files:
    x11/libcapplet       Makefile 
  Log:
  Add USE_CSTD=gnu89, let's see if it will fix the build.
  
  PR:             ports/150432
  Reported by:    Joel Ray Holveck <joelh@piquan.org>
  
  Revision  Changes    Path
  1.21      +2 -7      ports/x11/libcapplet/Makefile
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 3 Jeremy Messenger freebsd_committer freebsd_triage 2010-10-02 22:04:31 UTC 
State Changed
From-To: open->patched

I have committed a possible fix by add USE_CSTD=gnu89. I am not close this 
PR until I know it's fixed for sure.
Comment 4 Pav Lucistnik freebsd_committer freebsd_triage 2010-10-12 23:50:41 UTC 
State Changed
From-To: patched->open

Still very broken
Comment 5 Jeremy Messenger freebsd_committer freebsd_triage 2010-12-31 18:28:00 UTC 
State Changed
From-To: open->closed

The libcapplet will be removed, see here: ports/153355