On our Redmine I always wanted to use HTTP authentication and there is a plugin for it: http://github.com/AdamLantos/redmine_http_auth/ Fix: I had created FreeBSD port for this plugin; shar(1) archive is available at the following URL: http://codelabs.ru/fbsd/ports/redmine-http-auth/initial-port.shar The archive also contains www/redmine/bsd.redmine.mk, the foundation for all simple Redmine plugins: it features automated installation and creation of packaging list for the plugins that can just be dropped to the vendor/plugin directory of Redmine. As per the manual, http://www.redmine.org/wiki/redmine/Plugins it is the standard way to proceed. It will be good if Bernhard will do the review for the bsd.redmine.mk (and the new port too) and possibly approve this addition. How-To-Repeat: N/A
Responsible Changed From-To: freebsd-ports-bugs->miwi miwi@ wants his PRs (via the GNATS Auto Assign Tool)
Thanks for the work! It looks good to me but a few minor things could be improved. - I think it would be good to ignore *.orig files from PLIST and installing because it would be a pain whenever there is a plugin port that needs patches. - Why is there a build dependency to www/redmine in bsd.redmine.mk AND redmine-http-auth but no RUN_DEPENDS on www/redmine anywhere? - Comments in bsd.redmine.mk could be improved a little bit too -- Bernhard Froehlich http://www.bluelife.at/
Bernhard, good day. Mon, Sep 13, 2010 at 08:19:43AM +0000, Bernhard Froehlich wrote: > - I think it would be good to ignore *.orig files from PLIST and > installing because it would be a pain whenever there is a plugin port > that needs patches. Yes, I had fixed this. > - Why is there a build dependency to www/redmine in bsd.redmine.mk AND > redmine-http-auth but no RUN_DEPENDS on www/redmine anywhere? Oops: thanks for spotting, these were artifacts from the old version of the port. Now only RUN_DEPENDS are set in the bsd.redmine.mk since nothing in the current implementation depends on the Redmine to be present during the build phase. > - Comments in bsd.redmine.mk could be improved a little bit too I had improved them (a bit) mostly by rewording some sentences, slightly expanding comments and adding the example of the simple plugin Makefile. The updated shar(1) archive is still available at the old URL: http://codelabs.ru/fbsd/ports/redmine-http-auth/initial-port.shar Thanks for the valuable review! -- Eygene _ ___ _.--. # \`.|\..----...-'` `-._.-'_.-'` # Remember that it is hard / ' ` , __.--' # to read the on-line manual )/' _/ \ `-_, / # while single-stepping the kernel. `-'" `"\_ ,_.-;_.-\_ ', fsc/as # _.-'_./ {_.' ; / # -- FreeBSD Developers handbook {_.-``-' {_/ #
On Wed, 15 Sep 2010 11:41:07 +0400, Eygene Ryabinkin <rea-fbsd@codelabs.ru> wrote: > Bernhard, good day. > > Mon, Sep 13, 2010 at 08:19:43AM +0000, Bernhard Froehlich wrote: >> - I think it would be good to ignore *.orig files from PLIST and >> installing because it would be a pain whenever there is a plugin port >> that needs patches. > > Yes, I had fixed this. > >> - Why is there a build dependency to www/redmine in bsd.redmine.mk AND >> redmine-http-auth but no RUN_DEPENDS on www/redmine anywhere? > > Oops: thanks for spotting, these were artifacts from the old version > of the port. Now only RUN_DEPENDS are set in the bsd.redmine.mk > since nothing in the current implementation depends on the Redmine > to be present during the build phase. > >> - Comments in bsd.redmine.mk could be improved a little bit too > > I had improved them (a bit) mostly by rewording some sentences, > slightly expanding comments and adding the example of the simple > plugin Makefile. > > The updated shar(1) archive is still available at the old URL: > http://codelabs.ru/fbsd/ports/redmine-http-auth/initial-port.shar > > Thanks for the valuable review! Thank you very much for your work! It looks fine to me now. -- Bernhard Froehlich http://www.bluelife.at/
Wed, Sep 15, 2010 at 08:03:29AM +0000, Bernhard Froehlich wrote: > Thank you very much for your work! It looks fine to me now. By the way, may be it will worth to put bsd.redmine.mk into /usr/ports/Mk? It might be easier for people to locate this file and use it for plugins. I can do the needed modifications to bsd.port.mk to add USE_REDMINE knob and associated stuff if the consensus will be that such modifications will be worthwile. -- Eygene _ ___ _.--. # \`.|\..----...-'` `-._.-'_.-'` # Remember that it is hard / ' ` , __.--' # to read the on-line manual )/' _/ \ `-_, / # while single-stepping the kernel. `-'" `"\_ ,_.-;_.-\_ ', fsc/as # _.-'_./ {_.' ; / # -- FreeBSD Developers handbook {_.-``-' {_/ #
Responsible Changed From-To: miwi->rea Grab my own PR.
rea 2010-11-26 13:53:56 UTC FreeBSD ports repository Modified files: www Makefile Added files: www/redmine bsd.redmine.mk www/redmine-http-auth Makefile distinfo pkg-descr Log: New port: www/redmine-http-auth Plugin for doing HTTP-based authentication in Redmine. Also contains the generic module, bsd.redmine.mk, for making Redmine plugins. Reviewed by: decke Approved by: garga (mentor) PR: ports/150507 Revision Changes Path 1.2752 +1 -0 ports/www/Makefile 1.1 +20 -0 ports/www/redmine-http-auth/Makefile (new) 1.1 +2 -0 ports/www/redmine-http-auth/distinfo (new) 1.1 +3 -0 ports/www/redmine-http-auth/pkg-descr (new) 1.1 +80 -0 ports/www/redmine/bsd.redmine.mk (new) _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
State Changed From-To: open->closed Commited new port with bsd.redmine.mk inside www/redmine directory, as it was originally discussed.