This change fixes the build when an alternate LOCALBASE is used. Port maintainer (avg@icyb.net.ua) is cc'd. Generated with FreeBSD Port Tools 0.99
Maintainer of sysutils/superiotool, Please note that PR ports/150604 has just been submitted. If it contains a patch for an upgrade, an enhancement or a bug fix you agree on, reply to this email stating that you approve the patch and a committer will take care of it. The full text of the PR can be found at: http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/150604 -- Edwin Groothuis via the GNATS Auto Assign Tool edwin@FreeBSD.org
State Changed From-To: open->feedback Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Tim Bishop <tim@bishnet.net> writes: > --- superiotool-20090930.patch begins here --- > Index: Makefile > =================================================================== > RCS file: /u1/freebsd/cvs/ports/sysutils/superiotool/Makefile,v > retrieving revision 1.3 > diff -u -r1.3 Makefile > --- Makefile 1 Apr 2010 05:32:03 -0000 1.3 > +++ Makefile 15 Sep 2010 20:28:58 -0000 > @@ -37,6 +37,7 @@ > > post-patch: > @${REINPLACE_CMD} -e 's#/share/man/#/man/#g' -e 's#-ansi##g' \ > + -e 's#/usr/local#${PREFIX}#g' \ You can use `?=' as well. And it'd be useful in a few more places. --- a.diff begins here --- Index: sysutils/superiotool/Makefile =================================================================== RCS file: /a/.cvsup/ports/sysutils/superiotool/Makefile,v retrieving revision 1.3 diff -u -p -r1.3 Makefile --- sysutils/superiotool/Makefile 1 Apr 2010 05:32:03 -0000 1.3 +++ sysutils/superiotool/Makefile 15 Sep 2010 21:41:03 -0000 @@ -37,6 +37,8 @@ gen-dist: post-patch: @${REINPLACE_CMD} -e 's#/share/man/#/man/#g' -e 's#-ansi##g' \ + -Ee '\#^(CC|INSTALL|PREFIX)#s#=#?=#' \ + -e '\#^CFLAGS#s#=#+=#' -e 's#-O2##' \ ${WRKSRC}/Makefile .include <bsd.port.pre.mk> --- a.diff ends here ---
Guys, if you need that functionality and you tested the patches and they work, then I approve. Tim's patch is simple enough for me to see through it, but Anonymous' patch seems to be more comprehensive. If changing '=' to '?=' makes the build really honor values set by port's Makefile, then this change seems to be preferable. Thanks! -- Andriy Gapon
Andriy Gapon <avg@icyb.net.ua> writes: > Guys, > > if you need that functionality and you tested the patches and they work, then I > approve. Well, I do need the port to respect CC[1] and CFLAGS[2] because I use gcc45 and build all my ports with debug symbols, sometimes with -O0. The tool's output doesn't seem to change after applying my diff. But I don't really use the port. [1] http://www.freebsd.org/doc/en/books/porters-handbook/dads-cc.html [2] http://www.freebsd.org/doc/en/books/porters-handbook/dads-cflags.html > Tim's patch is simple enough for me to see through it, but Anonymous' patch > seems to be more comprehensive. If changing '=' to '?=' makes the build really > honor values set by port's Makefile, then this change seems to be preferable. Nah, there is little difference between hardcoding value into Makefile by REINPLACE_CMD and using `?='.
Responsible Changed From-To: freebsd-ports-bugs->pgollucci I will take it
State Changed From-To: feedback->open Feedback received
Responsible Changed From-To: pgollucci->freebsd-ports-bugs going to have enotime for the next 2 weeks, sorry
Responsible Changed From-To: freebsd-ports-bugs->makc I'll take it.
makc 2010-09-25 18:20:25 UTC FreeBSD ports repository Modified files: sysutils/superiotool Makefile Log: Respect PREFIX and CFLAGS PR: ports/150604 Submitted by: Tim Bishop <tim at bishnet.net> Reviewed by: Anonymous <swell.k at gmail.com> Approved by: Andriy Gapon (maintainer) Revision Changes Path 1.4 +2 -0 ports/sysutils/superiotool/Makefile _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
State Changed From-To: open->closed Committed. Thanks!