Bug 150982 - [patch] net-p2p/ed2k: typo and wrong amule pkgname in CONFLICTS
Summary: [patch] net-p2p/ed2k: typo and wrong amule pkgname in CONFLICTS
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Dirk Meyer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-09-27 09:30 UTC by swell.k
Modified: 2010-10-05 19:50 UTC (History)
0 users

See Also:

Attachments
a.diff (1.26 KB, patch)
2010-09-27 09:30 UTC, swell.k 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description swell.k 2010-09-27 09:30:07 UTC 
- fix typo: CONFILTCS vs. CONFLICTS
- use current lowercase amule pkgname in CONFLICTS
- stop altering PKGNAME, PKGNAMESUFFIX2 doesn't exist anyway
- don't abuse LDLIBS for CPPFLAGS
- use NO_WRKSUBDIR
- install verbosely like most ports do
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2010-09-27 09:30:18 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->dinoex

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 dfilter service freebsd_committer freebsd_triage 2010-10-05 09:46:44 UTC 
dinoex      2010-10-05 08:46:40 UTC

  FreeBSD ports repository

  Modified files:
    net-p2p/ed2k         Makefile 
  Log:
  - fix typo: CONFILTCS vs. CONFLICTS
  - use current lowercase amule pkgname in CONFLICTS
  - don't abuse LDLIBS for CPPFLAGS
  - use NO_WRKSUBDIR
  - install verbosely like most ports do
  PR:             150982
  Submitted by:   swell.k
  
  - Fix PKGNAME logic
  
  Revision  Changes    Path
  1.4       +11 -8     ports/net-p2p/ed2k/Makefile
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 3 Dirk Meyer freebsd_committer freebsd_triage 2010-10-05 09:55:06 UTC 
State Changed
From-To: open->closed

committed with small chenags, thanks. 

regression found: 
CFLAGS+= was not passed if you have CFLAGS in /etc/make.conf
Comment 4 swell.k 2010-10-05 16:35:03 UTC 
(subject modified for gnats)

Dirk Meyer <dinoex@FreeBSD.org> writes:

> regression found:
> CFLAGS+= was not passed if you have CFLAGS in /etc/make.conf

Did you by chance use CFLAGS= instead of CFLAGS+= in make.conf?

> dinoex      2010-10-05 08:46:40 UTC
>
>   FreeBSD ports repository
>
>   Modified files:
>     net-p2p/ed2k         Makefile
>   Log:
>   - fix typo: CONFILTCS vs. CONFLICTS

Typo is still there.

>   - use current lowercase amule pkgname in CONFLICTS
>   - don't abuse LDLIBS for CPPFLAGS
>   - use NO_WRKSUBDIR
>   - install verbosely like most ports do
>   PR:             150982
>   Submitted by:   swell.k

>   - Fix PKGNAME logic

It breaks CONFLICTS in amule ports even more.
And remove PKGNAMESUFFIX2 if it's not defined anywhere.
Comment 5 dfilter service freebsd_committer freebsd_triage 2010-10-05 19:41:05 UTC 
dinoex      2010-10-05 18:40:58 UTC

  FreeBSD ports repository

  Modified files:
    net-p2p/ed2k         Makefile 
  Log:
  _ fix typo in CONFILTCS
  PR:             150982
  
  Revision  Changes    Path
  1.5       +1 -1      ports/net-p2p/ed2k/Makefile
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"