--with-glib=auto is the default 'configure' behavior. But 0.19.2 fails to link if glib is detected at the time configure is run: ../lib/.libs/libfribidi.so: undefined reference to `g_assert' The reason is that g_assert is not defined because glib/gtestutils.h is not included. This was noticed with glib-2.24.2, but likely occurs with other versions of glib, too. It was fixed in cvs upstream ... http://lists.freedesktop.org/archives/fribidi/2010-February/000598.html ... but no new release has been made. For 0.19.2 in ports, just use --without-glib (which is effectively how pointyhat builds it since glib is not a dependency). The patch below does that. It also fixes the URL in pkg-descr. Fix: --xWFuU/5WGn Content-Type: text/plain; name="patch-without-glib" Content-Description: fix fribidi 0.19.2 if glib installed Content-Disposition: inline; filename="patch-without-glib" Content-Transfer-Encoding: 7bit --xWFuU/5WGn----69OTQMRukXmzr97Lu2wXhsZzIybupxsgGyR7Sd1Itxnx0Q0J Content-Type: text/plain; name="file.diff" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="file.diff" Index: Makefile =================================================================== RCS file: /base/FreeBSD-CVS/ports/converters/fribidi/Makefile,v retrieving revision 1.22 diff -u -p -r1.22 Makefile --- Makefile 23 Aug 2009 17:17:33 -0000 1.22 +++ Makefile 3 Oct 2010 01:18:30 -0000 @@ -42,6 +42,8 @@ MAN3= fribidi_charset_to_unicode.3 frib CONFIGURE_ARGS= --disable-debug .endif +CONFIGURE_ARGS+= --without-glib + post-patch: @${SED} -e 's|%%LOCALBASE%%|${LOCALBASE}|g' < \ ${FILESDIR}/fribidi-config > ${WRKDIR}/fribidi-config Index: pkg-descr =================================================================== RCS file: /base/FreeBSD-CVS/ports/converters/fribidi/pkg-descr,v retrieving revision 1.3 diff -u -p -r1.3 pkg-descr --- pkg-descr 12 Sep 2005 07:29:08 -0000 1.3 +++ pkg-descr 3 Oct 2010 01:23:56 -0000 @@ -17,4 +17,4 @@ every Unicode character will be treated specification. The same is true for the mirroring of characters, which also works for all the characters listed as mirrorable in the Unicode specification. -WWW: http://fribidi.org/wiki/ +WWW: http://fribidi.org/ How-To-Repeat: Install devel/glib20. Then try to build converters/fribidi.
Responsible Changed From-To: freebsd-ports-bugs->gnome Over to maintainer (via the GNATS Auto Assign Tool)
I think it affects only default LOCALBASE. With non-default one configure script won't find pkg-config and won't check glib version.
mezz 2010-10-03 15:45:37 UTC FreeBSD ports repository Modified files: converters/fribidi Makefile pkg-descr Log: -Disable glib for it will not enable if it exists in the system. -Update the WWW. PR: ports/151166 Submitted by: John Hein <jhein@symmetricom.com> Revision Changes Path 1.23 +3 -2 ports/converters/fribidi/Makefile 1.4 +1 -1 ports/converters/fribidi/pkg-descr _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
State Changed From-To: open->closed Committed, thanks!
Anonymous wrote at 07:34 +0400 on Oct 3, 2010: > I think it affects only default LOCALBASE. With non-default one > configure script won't find pkg-config and won't check glib version. Sure. Putting it another way, if pkg-config is not in your path or glib-2.0.pc is not in PKG_CONFIG_PATH and/or the pkg-config default search path, then fribidi's configure will not detect glib and the build of fribidi will not fail. But in most cases I think it's accurate to say that if someone has devel/glib20 installed, fribidi's build will fail.
John Hein <jhein@symmetricom.com> writes: > Anonymous wrote at 07:34 +0400 on Oct 3, 2010: > > I think it affects only default LOCALBASE. With non-default one > > configure script won't find pkg-config and won't check glib version. > > Sure. Putting it another way, if pkg-config is not in your path or FYI, pkg-config *is* in my PATH. If I move PKG_CHECK_MODULES out of if-then-else condition it works, it also works if I define PKG_CONFIG in environment.
For the sake of PR posterity, upstream comments on the need (or not) for glib... http://lists.freedesktop.org/archives/fribidi/2010-October/000605.html Basically, it's currently not needed (but I imagine for some platforms might help with portability issues).