The script /usr/local/etc/rc.d/cruisecontrolrb doesn't shut down builder processes when run with the 'stop' argument. Since the PID files of the builders are also left behind, this means that cruisecontrol.rb will not start automatically on server reboot. Fix: Attached is a patch to the rc.d script, which terminates the builders and removes their PID files when run with the 'stop' argument. Patch attached with submission follows: How-To-Repeat: Configure some projects in cruisecontrol.rb Start the dashboard and builders: /usr/local/etc/rc.d/cruisecontrolrb start Now run: /usr/local/etc/rc.d/cruisecontrolrb stop And then again: /usr/local/etc/rc.d/cruisecontrolrb start Notice that cruisecontrol.rb was not started.
Responsible Changed From-To: freebsd-ports-bugs->ruby Over to maintainer (via the GNATS Auto Assign Tool)
Responsible Changed From-To: ruby->pgollucci I will take it.
pgollucci 2010-11-11 03:34:47 UTC FreeBSD ports repository Modified files: www/ruby-cruisecontrolrb/files cruisecontrolrb.in Log: - Correctly stop both mongrel, and the builder instances which may be several different pids. PR: ports/151840 Submitted by: Toomas Aas <toomas@tarkvarastuudio.ee> Sponsored by: RideCharge Inc. / TaxiMagic Revision Changes Path 1.5 +7 -1 ports/www/ruby-cruisecontrolrb/files/cruisecontrolrb.in _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
State Changed From-To: open->closed Committed, Thanks!