Bug 151840 - www/ruby-cruisecontrolrb rc.d script doesn't clean up on stop
Summary: www/ruby-cruisecontrolrb rc.d script doesn't clean up on stop
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Philip M. Gollucci
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-10-30 22:40 UTC by Toomas Aas
Modified: 2010-11-11 03:40 UTC (History)
0 users

See Also:


Attachments
file.txt (154 bytes, text/plain)
2010-10-30 22:40 UTC, Toomas Aas
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Toomas Aas 2010-10-30 22:40:11 UTC
The script /usr/local/etc/rc.d/cruisecontrolrb doesn't shut down builder processes when run with the 'stop' argument. Since the PID files of the builders are also left behind, this means that cruisecontrol.rb will not start automatically on server reboot.

Fix: Attached is a patch to the rc.d script, which terminates the builders and removes their PID files when run with the 'stop' argument.

Patch attached with submission follows:
How-To-Repeat: Configure some projects in cruisecontrol.rb

Start the dashboard and builders:
/usr/local/etc/rc.d/cruisecontrolrb start

Now run:
/usr/local/etc/rc.d/cruisecontrolrb stop

And then again:
/usr/local/etc/rc.d/cruisecontrolrb start

Notice that cruisecontrol.rb was not started.
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2010-10-30 22:40:17 UTC
Responsible Changed
From-To: freebsd-ports-bugs->ruby

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 Philip M. Gollucci freebsd_committer freebsd_triage 2010-11-11 02:32:28 UTC
Responsible Changed
From-To: ruby->pgollucci

I will take it.
Comment 3 dfilter service freebsd_committer freebsd_triage 2010-11-11 03:34:53 UTC
pgollucci    2010-11-11 03:34:47 UTC

  FreeBSD ports repository

  Modified files:
    www/ruby-cruisecontrolrb/files cruisecontrolrb.in 
  Log:
  - Correctly stop both mongrel, and the builder instances which may be
    several different pids.
  
  PR:             ports/151840
  Submitted by:   Toomas Aas <toomas@tarkvarastuudio.ee>
  Sponsored by:   RideCharge Inc. / TaxiMagic
  
  Revision  Changes    Path
  1.5       +7 -1      ports/www/ruby-cruisecontrolrb/files/cruisecontrolrb.in
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 4 Philip M. Gollucci freebsd_committer freebsd_triage 2010-11-11 03:34:57 UTC
State Changed
From-To: open->closed

Committed, Thanks!