Bug 152102 - [patch] Mk/bsd.port.mk: make dirrmtry more friendly
Summary: [patch] Mk/bsd.port.mk: make dirrmtry more friendly
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Mark Linimon
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-11-10 10:40 UTC by Andrej Zverev
Modified: 2011-02-25 01:00 UTC (History)
0 users

See Also:


Attachments
bsd.port.mk.diff (575 bytes, patch)
2010-11-10 10:40 UTC, Andrej Zverev
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andrej Zverev freebsd_committer freebsd_triage 2010-11-10 10:40:13 UTC
	We have several ports net/wired, games/inorm7, www/dalbum that contain
	spaces in the directory structure (pkg-plist). To delete a file everything 
	works out of the box, but to delete the directory need to escape spaces.
	
	This patch should solve the problem, but after using it to break down these 
	three ports, which is not difficult to fix.

Examples

Before:
	@dirrmtry This is spaces - fail remove dir
	@dirrmtry This\ is \space - will work

After:
	@dirrmtry This is spaces - will work
	@dirrmtry This\ is\ spaces - fail :-)
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2010-11-10 10:40:51 UTC
Responsible Changed
From-To: freebsd-ports-bugs->portmgr

bsd.port.mk is portmgr territory (via the GNATS Auto Assign Tool)
Comment 2 Erwin Lansing freebsd_committer freebsd_triage 2011-01-02 18:09:17 UTC
State Changed
From-To: open->analyzed

Take for -exp run
Comment 3 Erwin Lansing freebsd_committer freebsd_triage 2011-01-10 13:45:10 UTC
State Changed
From-To: analyzed->feedback

This PR was run as a set of 144482, 152102 and 153625 
which had a large number of errors.  Errors directly 
related to this set may have been misanalysed or masked 
by errors from one of the other PRs.  Full set of logs at 
http://pointyhat.freebsd.org/errorlogs/i386-8-exp-failure.html 
(after January 8).   

The follow errors are from this PR: 
http://pointyhat.freebsd.org/errorlogs/i386-errorlogs/a.8-exp.20090507142441/devcpu-data-0.5.log 
http://pointyhat.freebsd.org/errorlogs/i386-errorlogs/a.8-exp.20090507142441/postgresql-contrib-8.2.19.log 
http://pointyhat.freebsd.org/errorlogs/i386-errorlogs/a.8-exp.20090507142441/argus-clients-2.0.6_1.log 
http://pointyhat.freebsd.org/errorlogs/i386-errorlogs/a.8-exp.20090507142441/wired-1.3.4.log 
http://pointyhat.freebsd.org/errorlogs/i386-errorlogs/a.8-exp.20090507142441/postgresql-contrib-8.4.6.log 
http://pointyhat.freebsd.org/errorlogs/i386-errorlogs/a.8-exp.20090507142441/postgresql-contrib-8.0.26_1.log 
http://pointyhat.freebsd.org/errorlogs/i386-errorlogs/a.8-exp.20090507142441/postgresql-contrib-8.1.23.log 
http://pointyhat.freebsd.org/errorlogs/i386-errorlogs/a.8-exp.20090507142441/postgresql-contrib-8.3.13.log 
http://pointyhat.freebsd.org/errorlogs/i386-errorlogs/a.8-exp.20090507142441/postgresql-contrib-7.4.30_1.log 
http://pointyhat.freebsd.org/errorlogs/i386-errorlogs/a.8-exp.20090507142441/postgresql-contrib-9.0.2.log 
http://pointyhat.freebsd.org/errorlogs/i386-errorlogs/a.8-exp.20090507142441/inform7-6F95.log 
http://pointyhat.freebsd.org/errorlogs/i386-errorlogs/a.8-exp.20090507142441/ssmtp-2.62.3.log 
http://pointyhat.freebsd.org/errorlogs/i386-errorlogs/a.8-exp.20090507142441/nss-pam-ldapd-0.7.7.log 
http://pointyhat.freebsd.org/errorlogs/i386-errorlogs/a.8-exp.20090507142441/p5-Devel-TraceUse-2.01.log 
http://pointyhat.freebsd.org/errorlogs/i386-errorlogs/a.8-exp.20090507142441/p5-Mail-CheckUser-1.21_1.log 
http://pointyhat.freebsd.org/errorlogs/i386-errorlogs/a.8-exp.20090507142441/p5-Mail-Verify-0.02.log 
http://pointyhat.freebsd.org/errorlogs/i386-errorlogs/a.8-exp.20090507142441/qpopper-4.0.9_3.log 
http://pointyhat.freebsd.org/errorlogs/i386-errorlogs/a.8-exp.20090507142441/ganglia-webfrontend-3.1.1_3.log 
http://pointyhat.freebsd.org/errorlogs/i386-errorlogs/a.8-exp.20090507142441/syslog-ng3-3.2.1_2.log 
http://pointyhat.freebsd.org/errorlogs/i386-errorlogs/a.8-exp.20090507142441/dalbum-140.152_2.log 
http://pointyhat.freebsd.org/errorlogs/i386-errorlogs/a.8-exp.20090507142441/freeswitch-sounds-1.0.13_1.log 
http://pointyhat.freebsd.org/errorlogs/i386-errorlogs/a.8-exp.20090507142441/p5-Rose-HTML-Objects-0.611.log
Comment 4 Erwin Lansing freebsd_committer freebsd_triage 2011-01-10 13:57:54 UTC
Responsible Changed
From-To: portmgr->az

Return to submitter for feedback.
Comment 6 Andrej Zverev freebsd_committer freebsd_triage 2011-02-03 08:05:53 UTC
State Changed
From-To: feedback->open

bsd.port.mk is portmgr territory  #2
Comment 7 Erwin Lansing freebsd_committer freebsd_triage 2011-02-05 16:01:42 UTC
State Changed
From-To: open->analyzed

Take for second -exp run.
Comment 10 Andrej Zverev freebsd_committer freebsd_triage 2011-02-06 13:54:33 UTC
State Changed
From-To: feedback->open

Please use patch from here: http://people.freebsd.org/~az/my.diff It's 
include change to bsd.ports.mk above and fixes to three ports.  Other 
two ports already fixed. Thank :-) 



Comment 11 Andrej Zverev freebsd_committer freebsd_triage 2011-02-06 13:54:33 UTC
Responsible Changed
From-To: az->portmgr

Please use patch from here: http://people.freebsd.org/~az/my.diff It's 
include change to bsd.ports.mk above and fixes to three ports.  Other 
two ports already fixed. Thank :-)
Comment 12 Mark Linimon freebsd_committer freebsd_triage 2011-02-22 05:25:40 UTC
State Changed
From-To: open->analyzed

take for -exp run. 


Comment 13 Mark Linimon freebsd_committer freebsd_triage 2011-02-22 05:25:40 UTC
Responsible Changed
From-To: portmgr->linimon
Comment 14 dfilter service freebsd_committer freebsd_triage 2011-02-25 00:56:56 UTC
linimon     2011-02-25 00:56:51 UTC

  FreeBSD ports repository

  Modified files:
    Mk                   bsd.port.mk 
    games/inform7        Makefile pkg-plist 
    net/wired            Makefile pkg-plist 
    www/dalbum           Makefile pkg-plist 
  Log:
  - make dirrmtry more friendly [1]
  - allow checking STRIP when WITH_DEBUG is defined [2]
  - unify the message with real URL by removing superfluous slash [3]
  
  PR:             152102 [1],
                  153539 [2],
                  154653 [3]
  Submitted by:   az [1],
                  Anonymous <swell dot k at gmail dot com> [2],
                  sunpoet [3]
  
  Revision  Changes    Path
  1.670     +9 -5      ports/Mk/bsd.port.mk
  1.5       +1 -0      ports/games/inform7/Makefile
  1.3       +4 -4      ports/games/inform7/pkg-plist
  1.11      +1 -0      ports/net/wired/Makefile
  1.4       +2 -2      ports/net/wired/pkg-plist
  1.5       +1 -1      ports/www/dalbum/Makefile
  1.3       +1 -1      ports/www/dalbum/pkg-plist
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 15 Mark Linimon freebsd_committer freebsd_triage 2011-02-25 00:57:02 UTC
State Changed
From-To: analyzed->closed

Committed, thanks.