Bug 153392 - Update rc.d script for x11/slim
Summary: Update rc.d script for x11/slim
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Doug Barton
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-12-23 06:00 UTC by Doug Barton
Modified: 2011-01-08 08:10 UTC (History)
0 users

See Also:

Attachments
file.diff (1.58 KB, patch)
2010-12-23 06:00 UTC, Doug Barton 		no flags Details | Diff
slim_rc.patch (1.19 KB, patch)
2011-01-02 06:48 UTC, Henry Hu 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Doug Barton freebsd_committer freebsd_triage 2010-12-23 06:00:16 UTC 
	The script is currently unable to stop slim effectively
	because the X server instance will hang it. This patch
	adds a prestop method to fix that.

Fix: Apply the following patch:
How-To-Repeat: 	Start slim, attempt to stop it with the rc.d script
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2010-12-23 06:00:32 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->dougb

Submitter has GNATS access (via the GNATS Auto Assign Tool)
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2010-12-23 06:00:37 UTC 
Maintainer of x11/slim,

Please note that PR ports/153392 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/153392

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 3 Edwin Groothuis freebsd_committer freebsd_triage 2010-12-23 06:00:39 UTC 
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 4 Henry Hu 2011-01-02 06:48:41 UTC 
OK, I've verified the patch.

The problem really exists in the original file, try
/usr/local/etc/rc.d/slim start and then /usr/local/etc/rc.d/slim stop.
The patch fixed the problem.

However, this patch may still be refined. Currently, if I use the new
startup file, it would say "kill xxx: no such process" if I stop slim
using the script.

The PR page seems ruined, so I'm attaching the patch written by Doug
Barton again.
-- 
Cheers,
Henry
Comment 5 dfilter service freebsd_committer freebsd_triage 2011-01-08 08:05:34 UTC 
dougb       2011-01-08 08:05:29 UTC

  FreeBSD ports repository

  Modified files:
    x11/slim             Makefile 
    x11/slim/files       slim.sh.in 
  Log:
  Update rc.d script to effectively stop slim
  
  Maintainer assisted with testing various versions of the script.
  This final version seems to have addressed all of the issues that
  he and I saw.
  
  PR:             ports/153392
  Submitted by:   me
  
  Revision  Changes    Path
  1.24      +1 -0      ports/x11/slim/Makefile
  1.5       +28 -2     ports/x11/slim/files/slim.sh.in
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 6 Doug Barton freebsd_committer freebsd_triage 2011-01-08 08:05:52 UTC 
State Changed
From-To: feedback->closed


I committed the final version that I sent you in private mail. 

Thanks again! 

Doug