After the update to 9.10, rxvt-unicode fails to build here: cc -o rxvt rxvt.o background.o command.o rxvtfont.o init.o logging.o main.o misc.o ptytty.o proxy.o screen.o scrollbar.o scrollbar-next.o scrollbar-rxvt.o scrollbar-xterm.o scrollbar-plain.o xdefaults.o encoding.o rxvttoolkit.o rxvtutil.o keyboard.o fdpass.o ev_cpp.o -lm -lutil -lsupc++ -lm -L/usr/local/lib -lfontconfig -L/usr/local/lib -lXft -lXrender -lfontconfig -lfreetype -lX11 -L/usr/local/lib -lXrender -lX11 -L/usr/local/lib -R/usr/local/lib -lX11 background.o(.text+0x134a): In function `bgPixmap_t::render()': : undefined reference to `byteorder::e' My options: # make showconfig ===> The following configuration options are available for rxvt-unicode-9.10: PERL=off "Embedded perl interpreter" XIM=on "Support for XIM (X Input Method) protocol" UNICODE3=on "Support Unicode codepoints above 65535" ISO14755=on "Support for extended ISO 14755 modes" COMBINING=on "Automatic composition of combining chars" RXVT_SCROLLBAR=off "Support for the original rxvt scrollbar" NEXT_SCROLLBAR=off "Support for a NeXT-like scrollbar" XTERM_SCROLLBAR=off "Support for an Xterm-like scrollbar" BACKSPACE_KEY=on "Handling of the backspace key by rxvt" DELETE_KEY=on "Handling of the delete key by rxvt" MOUSEWHEEL=off "Support for scrolling via mouse wheel" SMART_RESIZE=on "Smart growth/shrink behaviour" IMLOCALE_FIX=off "imlocale encoding conversion fix" AFTERIMAGE=off "Use libAfterImage for background images" 256_COLOR=on "Support for 256 colors" How-To-Repeat: Try to build rxvt-unicode 9.10.
Responsible Changed From-To: freebsd-ports-bugs->thierry Over to maintainer (via the GNATS Auto Assign Tool)
At Wed, 29 Dec 2010 11:40:12 GMT, thierry@FreeBSD.org wrote: > Could you please test the hereunder patch, and let me know if it works > for you? Hi, It built fine here with the patch you attached. Does upstream know abut it?
thierry 2010-12-31 10:27:21 UTC FreeBSD ports repository Added files: x11/rxvt-unicode/files patch-src_background.C patch-src_rxvtutil.h Log: Fix a problem dur to a missing byteorder.h, revealed when AfterImage support is deactivated. PR: ports/153508 Submitted by: Raphael Kubo da Costa <kubito (at) gmail (dot) com> Revision Changes Path 1.1 +29 -0 ports/x11/rxvt-unicode/files/patch-src_background.C (new) 1.1 +18 -0 ports/x11/rxvt-unicode/files/patch-src_rxvtutil.h (new) _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Le ven 31 déc 10 à 1:18:16 +0100, Raphael Kubo da Costa <kubito@gmail.com> écrivait : > At Wed, 29 Dec 2010 11:40:12 GMT, > thierry@FreeBSD.org wrote: > > Could you please test the hereunder patch, and let me know if it works > > for you? > > Hi, Hello, > It built fine here with the patch you attached. Does upstream know > abut it? Not yet: I was waiting for your feedback, and I've just commited it. Now, I'm going to report it to the author. Regards, -- Th. Thomas.
State Changed From-To: open->feedback Could you please test the hereunder patch, and let me know if it works for you? --- rxvt-unicode.diff begins here --- diff -urN x11/rxvt-unicode.orig/files/patch-src_background.C x11/rxvt-unicode/files/patch-src_background.C --- x11/rxvt-unicode.orig/files/patch-src_background.C 1970-01-01 01:00:00.000000000 +0100 +++ x11/rxvt-unicode/files/patch-src_background.C 2010-12-29 12:28:09.000000000 +0100 @@ -0,0 +1,29 @@ +--- ./src/background.C.orig 2010-12-03 22:08:19.000000000 +0100 ++++ ./src/background.C 2010-12-29 12:27:37.000000000 +0100 +@@ -56,6 +56,10 @@ + #define TIMING_TEST_PRINT_RESULT(id) do {} while (0) + #endif + ++#if defined( __FreeBSD__) ++# include <sys/endian.h> ++#endif ++ + /* + * Pixmap geometry string interpretation : + * Each geometry string contains zero or one scale/position +@@ -1596,7 +1600,15 @@ + rgba low; + rgba high; + int i; ++#if defined(HAVE_SYS_BYTEORDER_H) + int host_byte_order = byteorder.big_endian () ? MSBFirst : LSBFirst; ++#else ++# if _BYTE_ORDER == _LITTLE_ENDIAN ++ int host_byte_order = LSBFirst; ++# else ++ int host_byte_order = MSBFirst; ++# endif ++#endif + + if (visual->c_class != TrueColor || ximage->format != ZPixmap) return; + diff -urN x11/rxvt-unicode.orig/files/patch-src_rxvtutil.h x11/rxvt-unicode/files/patch-src_rxvtutil.h --- x11/rxvt-unicode.orig/files/patch-src_rxvtutil.h 1970-01-01 01:00:00.000000000 +0100 +++ x11/rxvt-unicode/files/patch-src_rxvtutil.h 2010-12-29 12:29:50.000000000 +0100 @@ -0,0 +1,18 @@ +--- src/rxvtutil.h.orig 2010-08-25 04:07:15.000000000 +0200 ++++ src/rxvtutil.h 2010-12-29 12:29:26.000000000 +0100 +@@ -40,6 +40,7 @@ + # define THROW(x) throw x + #endif + ++#if defined(HAVE_SYS_BYTEORDER_H) + extern class byteorder { + static unsigned int e; // at least 32 bits + public: +@@ -50,6 +51,7 @@ + static bool little_endian () { return e == 0x44332211; }; + static bool vax () { return e == 0x44332211; }; + } byteorder; ++#endif + + // various utility functions + template<typename T, typename U> static inline T min (T a, U b) { return a < (T)b ? a : (T)b; } --- rxvt-unicode.diff ends here ---
State Changed From-To: feedback->closed Committed! Thanks for the report.