Bug 153540 - [patch] multimedia/ffmpeg: respect STRIP
Summary: [patch] multimedia/ffmpeg: respect STRIP
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Martin Matuska
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-12-30 10:10 UTC by swell.k
Modified: 2011-03-26 09:30 UTC (History)
0 users

See Also:


Attachments
a.diff (1.04 KB, patch)
2010-12-30 10:10 UTC, swell.k
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description swell.k 2010-12-30 10:10:08 UTC
- don't strip debug binaries[1]
- use yasm debug flags for WITH_DEBUG

[1] unless ports/153539 is fixed WITH_DEBUG needs either STRIP
    explicitly re-defined or DEBUG_FLAGS defined

How-To-Repeat: $ make install WITH_DEBUG=
$ STRIP= make install

$ file PREFIX/lib/libavcodec.so.*.*.*
/usr/local/lib/libavcodec.so.52.72.2: ELF 64-bit LSB shared object, x86-64, version 1 (FreeBSD), dynamically linked, stripped
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2010-12-30 10:10:15 UTC
Responsible Changed
From-To: freebsd-ports-bugs->mm

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 dfilter service freebsd_committer freebsd_triage 2011-03-22 07:35:11 UTC
mm          2011-03-22 07:34:47 UTC

  FreeBSD ports repository

  Modified files:
    multimedia/ffmpeg-devel Makefile distinfo pkg-plist 
    multimedia/ffmpeg-devel/files patch-configure 
  Log:
  - Update to 2011-03-21
  - Add LICENSE information
  - If linking against libfaac, set to RESTRICTED
  - Respect WITH_DEBUG [1]
  - Change WITH_VDPAU to a build-time dependency [2]
  - Add new option WITH_VAAPI (multimedia/libva) [3]
  - Accept x264_devel if installed
  
  PR:             ports/153540 [1], ports/153581 [2], ports/153727 [3]
  Submitted by:   swell.k@gmail.com [1] [2] [3]
  
  Revision  Changes    Path
  1.137     +32 -8     ports/multimedia/ffmpeg-devel/Makefile
  1.49      +2 -2      ports/multimedia/ffmpeg-devel/distinfo
  1.19      +11 -9     ports/multimedia/ffmpeg-devel/files/patch-configure
  1.33      +9 -15     ports/multimedia/ffmpeg-devel/pkg-plist
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 3 dfilter service freebsd_committer freebsd_triage 2011-03-22 07:38:59 UTC
mm          2011-03-22 07:38:46 UTC

  FreeBSD ports repository

  Modified files:
    multimedia/ffmpeg    Makefile distinfo 
  Log:
  - Add LICENSE information
  - If linking against libfaac, set RESTRICTED
  - Respect WITH_DEBUG [1]
  - Change WITH_VDPAU to a build-time dependency [2]
  - Add new option WITH_VAAPI (multimedia/libva) [3]
  
  PR:             ports/153540 [1], ports/153581 [2], ports/153727 [3]
  Submitted by:   swell.k@gmail.com
  
  Revision  Changes    Path
  1.122     +26 -6     ports/multimedia/ffmpeg/Makefile
  1.21      +0 -1      ports/multimedia/ffmpeg/distinfo
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 4 Martin Matuska freebsd_committer freebsd_triage 2011-03-22 08:11:14 UTC
State Changed
From-To: open->closed

Committed, with minor changes. Thanks!
Comment 5 Pan Tsu 2011-03-26 09:24:54 UTC
I wouldn't call that "minor" change. It no longer respects STRIP, only WITH_DEBUG.
STRIP doesn't always imply the other, which is useful when debugging apps *with*
optimization. Even less people would put WITH_DEBUG in make.conf compared to
`-g' in CFLAGS + empty STRIP.