Bug 153541 - [patch] devel/git: respect STRIP for stripping
Summary: [patch] devel/git: respect STRIP for stripping
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Renato Botelho
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-12-30 10:40 UTC by swell.k
Modified: 2016-06-11 20:23 UTC (History)
2 users (show)

See Also:

Attachments
a.diff (1022 bytes, patch)
2010-12-30 10:40 UTC, swell.k 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description swell.k 2010-12-30 10:40:09 UTC 
Strip binaries based on STRIP value, not only when WITH_DEBUG is used.
It's as ports/146961 originally intended.

depends on STRIP re-defined in bsd.port.pre.mk as per ports/153539
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2010-12-30 10:40:15 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->wxs

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 swell.k 2011-01-01 16:00:16 UTC 
the last diff from ports/153539 allows checking STRIP from bsd.port.options.mk

--- a.diff begins here ---
Index: devel/git/Makefile
===================================================================
RCS file: /a/.cvsup/ports/devel/git/Makefile,v
retrieving revision 1.96
diff -u -p -r1.96 Makefile
--- devel/git/Makefile	19 Dec 2010 07:48:18 -0000	1.96
+++ devel/git/Makefile	1 Jan 2011 15:13:33 -0000
@@ -195,7 +195,7 @@ OPTIONS=	GUI "Enable building of GUI too
 
 .include <bsd.port.options.mk>
 
-.ifndef (WITH_DEBUG)
+.if defined(STRIP) && ${STRIP} != ""
 ALL_TARGET=	all strip
 .endif
 
--- a.diff ends here ---
Comment 3 Carlo Strub freebsd_committer freebsd_triage 2014-09-07 19:52:39 UTC 
Is this PR still relevant?
Comment 4 Mark Linimon freebsd_committer freebsd_triage 2015-09-03 07:02:54 UTC 
Over to current maintainer.
Comment 5 commit-hook freebsd_committer freebsd_triage 2016-06-11 20:22:28 UTC 
A commit references this bug:

Author: garga
Date: Sat Jun 11 20:22:00 UTC 2016
New revision: 416750
URL: https://svnweb.freebsd.org/changeset/ports/416750

Log:
  Respect BSD's STRIP instead of checking only WITH_DEBUG

  PR:		153541
  Submitted by:	swell.k@gmail.com
  Sponsored by:	Rubicon Communications (Netgate)

Changes:
  head/devel/git/Makefile