Bug 153644 - patch for x11/xorg on powerpc needs to also be applied for powerpc64
Summary: patch for x11/xorg on powerpc needs to also be applied for powerpc64
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-x11 (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-01-03 06:10 UTC by Matthew Rezny
Modified: 2011-01-25 02:00 UTC (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matthew Rezny 2011-01-03 06:10:09 UTC 
The xorg-server port includes a file ppc_video.c which required a patch for FreeBSD as detailed in PR ports/118851. This patch should be applied to all PowerPC builds.

When building xorg-server-1.7.5,1 for powerpc64, a compilation error and subsequent linking error occurs in that file, halting the build. The Makefile applies the patch only when ARCH==powerpc, but it should apply the patch when (ARCH==powerpc || ARCH==powerpc64).

Fix: 

In the Makefile, change the first line of the following code fragment

.if ${ARCH} == powerpc
PLIST_SUB+=     PPC_NA="@comment "
MAN4+=          nv.4x
EXTRA_PATCHES=  ${.CURDIR}/files/extra-arch-powerpc
.else
PLIST_SUB+=     PPC_NA=""
.endif

to instead be

.if ${ARCH} == powerpc || ${ARCH} == powerpc64
How-To-Repeat: cd /usr/ports/x11-servers/xorg-server && make install clean
Comment 1 Tilman Keskinoz freebsd_committer freebsd_triage 2011-01-03 11:10:21 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->x11

Over to maintainers
Comment 2 Mark Linimon freebsd_committer freebsd_triage 2011-01-03 18:52:45 UTC 
Responsible Changed
From-To: x11->freebsd-x11

Canonicalize assignment.
Comment 3 dfilter service freebsd_committer freebsd_triage 2011-01-25 01:53:16 UTC 
stas        2011-01-25 01:53:11 UTC

  FreeBSD ports repository

  Modified files:
    x11-servers/xorg-server Makefile 
  Log:
  - Fix build on powerpc64.
  
  PR:             ports/147568, ports/153644
  Submitted by:   nwhitehorn, Matthew Rezny <mrezny@hexaneinc.com>
  Feature safe:   yes
  
  Revision  Changes    Path
  1.77      +1 -1      ports/x11-servers/xorg-server/Makefile
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 4 Stanislav Sedov freebsd_committer freebsd_triage 2011-01-25 01:53:53 UTC 
State Changed
From-To: open->closed

Committed. Thanks!