See attached Fix: Patch attached with submission follows:
Responsible Changed From-To: freebsd-ports-bugs->tobez Over to maintainer (via the GNATS Auto Assign Tool)
State Changed From-To: open->feedback Bumping PORTEPOCH is, in my opinion, not the right way to deal with this verision change. I would instead add an appropriate number of zeroes to the upastram version number and strip them to get the correct distfile (there are plenty of ports which do just that). This is mainly because there is no guarantee that the version number after decimal point will remain in hundreds and not explode into hundreds of thousands as in the current version in the ports collection, and back again. It is good to keep PORTEPOCH bumping as a measure of last resort.
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 01/29/11 13:25, tobez@FreeBSD.org wrote: > Synopsis: [PATCH] update devel/p5-CPAN-Mini > > State-Changed-From-To: open->feedback > State-Changed-By: tobez > State-Changed-When: Sat Jan 29 19:21:28 CET 2011 > State-Changed-Why: > Bumping PORTEPOCH is, in my opinion, not the right > way to deal with this verision change. I would > instead add an appropriate number of zeroes to the upastram version > number and strip them to get the correct distfile > (there are plenty of ports which do just that). > > This is mainly because there is no guarantee that > the version number after decimal point will remain > in hundreds and not explode into hundreds of thousands > as in the current version in the ports collection, > and back again. It is good to keep PORTEPOCH bumping > as a measure of last resort. > > http://www.freebsd.org/cgi/query-pr.cgi?pr=154378 Does the attached patch look like what you were suggesting? Thanks, Steve -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.16 (FreeBSD) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBAgAGBQJNRF+fAAoJEPXPYrMgexuhMWQH/AlzQB+mBrmPNaTdLEviLY1d DYPqqAjSmi63C3hrhqlWJIr48ov35gIi7uQtKv2mCqKeQcV8zVTua1Kx/D30gt3y JXa06jQTF5Xwomw5Yg0dhF9FX7JxzeJEwP8nWT8gLgMIsQw9S4gCCiI1OOB8IkZm pDqB5vDsagr1wJU+d13dSOcPTOwqh2MoAq5zMndsD8dMguCYDNaVddTLAq5HicUs A/NNlMc++VxT/E2h4g2QDONdtXyjLtyU3M+R20Qvs363UMubwcrTRcgyqVTXITlQ +RpM7aQhW9PF+Lk50SRMrSS+1LnZ9e+pSwPC/REKTokNQhegUGd4M3npU1FFIMQ= =hBZO -----END PGP SIGNATURE-----
tobez 2011-01-29 19:25:40 UTC FreeBSD ports repository Modified files: devel/p5-CPAN-Mini Makefile distinfo Log: Update to 1.110(000). Changes: http://search.cpan.org/dist/CPAN-Mini/Changes PR: 154378 Submitted by: Steve Wills <steve@mouf.net> Feature safe: yes Revision Changes Path 1.26 +4 -3 ports/devel/p5-CPAN-Mini/Makefile 1.20 +2 -3 ports/devel/p5-CPAN-Mini/distinfo _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
State Changed From-To: feedback->closed Yes, the latest patch looks good. I committed it with a minor modification of my own. Thank you for your submission.