Bug 154453 - Rewritten port: audio/teamspeak_server
Summary: Rewritten port: audio/teamspeak_server
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-02-01 21:40 UTC by hirner
Modified: 2011-05-03 23:10 UTC (History)
0 users

See Also:


Attachments
teamspeak_server.shar (42.39 KB, text/plain)
2011-02-01 21:40 UTC, hirner
no flags Details
teamspeak_server.shar (42.55 KB, application/x-shar)
2011-02-25 01:21 UTC, hirner
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description hirner 2011-02-01 21:40:08 UTC

Fix: Patch for /usr/ports/LEGAL:
--- LEGAL.orig  2011-02-01 20:55:41.000000000 +0100
+++ LEGAL       2011-02-01 20:55:49.000000000 +0100
@@ -552,6 +552,7 @@
                                                binaries is not permitted
 scv-1.0p2-sysc*                cad/scv                 License agreement required
 tcetest_*              games/linux-enemyterritory-tce  Redistribution limited
+teamspeak*             audio/teamspeak_server  No redistribtion
 texcm-ttf-20010117/*   x11-fonts/texcm-ttf     Cannot be sold or distributed
                                                with any commercial product
 thisTest.jar           devel/thistest          No redistribution of binaries


Patch for /usr/ports/UIDs:
--- UIDs.orig   2011-02-01 20:36:48.000000000 +0100
+++ UIDs        2011-02-01 20:37:03.000000000 +0100
@@ -192,3 +192,4 @@
 sancp:*:932:932::0:0:SANCP Daemon:/var/log/sancp:/sbin/nologin
 dlna:*:933:933::0:0:DLNA Daemon:/nonexistent:/sbin/nologin
 torrus:*:934:934::0:0:torrus daemon:/nonexistent:/sbin/nologin
+teamspeak:*:936:936::0:0:TeamSpeak user:/nonexistent:/sbin/nologin


--- GIDs.orig   2011-02-01 20:36:49.000000000 +0100
+++ GIDs        2011-02-01 20:37:04.000000000 +0100
@@ -184,3 +184,4 @@
 sancp:*:932:
 dlna:*:933:
 torrus:*:934:www
+teamspeak:*:936:
Comment 1 hirner 2011-02-25 01:21:54 UTC
With help from Chris Rees, there's a new version available that should
be used instead of my originally submitted one. The UIDs and GIDs
patches stay the same. The new patch is available here:

https://gist.github.com/96b54ed7ae3479584ba6 (you can use the "download"
button to get the tarballed shar)
Comment 2 Mark Linimon freebsd_committer freebsd_triage 2011-03-08 17:59:58 UTC
State Changed
From-To: open->repocopy

Note: this is a request for a repocopy, OTOH the PR may need some more 
work before it's ready.  (marcus: I'm not in a situation where I can 
work on this one myself.) 


Comment 3 Mark Linimon freebsd_committer freebsd_triage 2011-03-08 17:59:58 UTC
Responsible Changed
From-To: freebsd-ports-bugs->portmgr
Comment 4 Chris Rees 2011-03-08 18:47:03 UTC
Hi,

Before we get this committed, as discussed on IRC with linimon et al
we'll need a repocopy.

Please copy:

audio/teamspeak_server --> audio/teamspeak3-server [to kill underscore
as well as add version]

Updated shar at [1] as well as diff to (hopefully repocopied)
teamspeak3-server at [2],
followed by testruns on i386 7.4 [3], 8.2 [4], 9-CURRENT [5].

The diff is really for curiosity; the port has changed so much it's
kinda pointless-- as Richard mentioned earlier.

Richard, I've made a few more changes, please confirm if these are OK by you.

- Broken the lines on MASTER_SITES

- Moved bsd.port.pre.mk down; there's no need for multiple .if ARCH.
If you look at the DISTNAME,
    TEAMSPEAK_ARCH isn't evaluated until bsd.port.post.mk anyway, so
it's fine to use that
    variable in DISTNAME

- The port now respects NOPORTDOCS, _and_ installs the docs in the
correct place.

- I've also silenced the commands under the targets

- Added CONFLICTS for teamspeak_server previous versions

Chris

[1] http://www.bayofrum.net/~crees/patches/teamspeak3-server.shar
[2] http://www.bayofrum.net/~crees/patches/teamspeak3-server.diff
[3] http://www.bayofrum.net/~crees/tinderlogs/teamspeak3-server-f7.4.html
[4] http://www.bayofrum.net/~crees/tinderlogs/teamspeak3-server-f8.2.html
[5] http://www.bayofrum.net/~crees/tinderlogs/teamspeak3-server-f9.html
Comment 5 Chris Rees 2011-03-08 19:53:00 UTC
Richard has indicated his approval in an email to me:

---------- Forwarded message ----------
From: Richard Hirner <hirner@bitfire.at>
Date: 8 March 2011 19:04
Subject: Re: ports/154453: Rewritten port: audio/teamspeak_server
To: utisoft@gmail.com


Hello,

Thank you, the changes seem to be OK. (Didn't know that the
TEAMSPEAK_ARCH in lines at the top will be recognised even if declared
later)

Richard
Comment 6 Joe Marcus Clarke freebsd_committer freebsd_triage 2011-03-14 03:00:44 UTC
State Changed
From-To: repocopy->open

Repocopy complete.  Mark, can you find a committer to finish the work? 


Comment 7 Joe Marcus Clarke freebsd_committer freebsd_triage 2011-03-14 03:00:44 UTC
Responsible Changed
From-To: portmgr->linimon

Repocopy complete.  Mark, can you find a committer to finish the work?
Comment 8 hirner 2011-03-26 22:07:31 UTC
Any news on this? Is there a way how I can help finding a committer?
Comment 9 Mark Linimon freebsd_committer freebsd_triage 2011-03-27 02:06:10 UTC
Responsible Changed
From-To: linimon->freebsd-ports-bugs

Repcopy complete.  Please note, as I earlier said in the Audit-Trail, 
this should have not been assigned to me, as I don't have the cycles 
right now.  I was merely trying to fix the PR state when I intervened.
Comment 10 hirner 2011-04-13 21:23:41 UTC
In the meantime, the UID and GID entries should be changed ... because
the numbers are used for other ports now

Shall I update the proposed UID/GID changes?
Comment 11 Richard Hirner 2011-04-17 21:57:30 UTC
Just out of curiosity: how long does such a change request take
normally?

If I can help any further, please tell me what to do.
Comment 12 dfilter service freebsd_committer freebsd_triage 2011-05-03 23:06:20 UTC
glarkin     2011-05-03 22:06:11 UTC

  FreeBSD ports repository

  Modified files:
    .                    LEGAL UIDs GIDs 
    audio/teamspeak3-server Makefile distinfo pkg-descr pkg-plist 
  Added files:
    audio/teamspeak3-server/files LICENSE pkg-message.in 
                                  teamspeak.in 
  Removed files:
    audio/teamspeak3-server pkg-install 
    audio/teamspeak3-server/files teamspeak-server.in 
  Log:
  - Updated to 3.0.0.b30 [1]
  - Over to new volunteer [1]
  - Added new UID, GID, and LEGAL entries [1]
  - Fixed rc.conf variable name in pkg-message
  - Fixed a couple of portlint warnings
  
  PR:             ports/154453 [1]
  Submitted by:   Richard Hirner <hirner@bitfire.at>
  Reviewed by:    Chris Rees <utisoft@gmail.com>
  
  Revision  Changes    Path
  1.135     +2 -1      ports/GIDs
  1.655     +2 -1      ports/LEGAL
  1.150     +2 -1      ports/UIDs
  1.15      +63 -28    ports/audio/teamspeak3-server/Makefile
  1.8       +4 -4      ports/audio/teamspeak3-server/distinfo
  1.1       +153 -0    ports/audio/teamspeak3-server/files/LICENSE (new)
  1.1       +12 -0     ports/audio/teamspeak3-server/files/pkg-message.in (new)
  1.5       +0 -38     ports/audio/teamspeak3-server/files/teamspeak-server.in (dead)
  1.1       +38 -0     ports/audio/teamspeak3-server/files/teamspeak.in (new)
  1.3       +2 -3      ports/audio/teamspeak3-server/pkg-descr
  1.2       +0 -72     ports/audio/teamspeak3-server/pkg-install (dead)
  1.6       +247 -254  ports/audio/teamspeak3-server/pkg-plist
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 13 dfilter service freebsd_committer freebsd_triage 2011-05-03 23:09:10 UTC
glarkin     2011-05-03 22:09:02 UTC

  FreeBSD ports repository

  Modified files:
    audio                Makefile 
  Log:
  - Hook audio/teamspeak3-server into the build
  
  PR:             ports/154453
  
  Revision  Changes    Path
  1.1167    +1 -0      ports/audio/Makefile
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 14 Greg Larkin freebsd_committer freebsd_triage 2011-05-03 23:09:20 UTC
State Changed
From-To: open->closed

Committed with additional minor changes, thank you!