Bug 154680 - [PATCH] games/odamex add support for midi
Summary: [PATCH] games/odamex add support for midi
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-02-11 12:10 UTC by Aldis Berjoza
Modified: 2011-02-13 07:30 UTC (History)
0 users

See Also:

Attachments
file.diff (898 bytes, patch)
2011-02-11 12:10 UTC, Aldis Berjoza 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Aldis Berjoza 2011-02-11 12:10:09 UTC 
games/odamex doesn't play music. I found out, that if you install audio/timidity it will play music.

I attached patch for port, that allows adding optional dependency on audio/timidity.


Right now I don't know why, but this doesn't work with timidity++

Fix: Patch attached with submission follows:
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2011-02-11 12:10:16 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->Aldis.Berjoza

Submitter has GNATS access (via the GNATS Auto Assign Tool)
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2011-02-11 12:10:19 UTC 
Maintainer of games/odamex,

Please note that PR ports/154680 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/154680

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 3 Edwin Groothuis freebsd_committer freebsd_triage 2011-02-11 12:10:21 UTC 
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 4 Josh Rickmar 2011-02-12 17:33:40 UTC 
On Fri, Feb 11, 2011 at 12:10:19PM +0000, Edwin Groothuis wrote:
> Maintainer of games/odamex,
> 
> Please note that PR ports/154680 has just been submitted.
> 
> If it contains a patch for an upgrade, an enhancement or a bug fix
> you agree on, reply to this email stating that you approve the patch
> and a committer will take care of it.
> 
> The full text of the PR can be found at:
>     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/154680
> 
> -- 
> Edwin Groothuis via the GNATS Auto Assign Tool
> edwin@FreeBSD.org

I no longer run FreeBSD and so have no way to test this.  Could I
be removed as maintainer?

Thanks,

Josh Rickmar
Comment 5 dfilter service freebsd_committer freebsd_triage 2011-02-13 01:20:16 UTC 
linimon     2011-02-13 01:20:10 UTC

  FreeBSD ports repository

  Modified files:
    games/odamex         Makefile 
  Log:
  Maintainer is no longer using FreeBSD, so has asked to return this one
  to the pool.
  
  PR:             ports/154680 (Audit-Trail)
  
  Revision  Changes    Path
  1.8       +1 -1      ports/games/odamex/Makefile
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 6 Mark Linimon freebsd_committer freebsd_triage 2011-02-13 01:20:17 UTC 
State Changed
From-To: feedback->open

Maintainer has asked to step down.  Thanks for all your work in the past. 

To submitter: would you like to become the new maintainer?
Comment 7 Mark Linimon freebsd_committer freebsd_triage 2011-02-13 01:20:17 UTC 
Responsible Changed
From-To: Aldis.Berjoza->freebsd-ports-bugs
Comment 8 dfilter service freebsd_committer freebsd_triage 2011-02-13 07:29:44 UTC 
miwi        2011-02-13 07:29:39 UTC

  FreeBSD ports repository

  Modified files:
    games/odamex         Makefile 
  Log:
  - Add support for midi sound
  
  PR:             154680
  Submitted by:   "aldis@bsdroot.lv"
  
  Revision  Changes    Path
  1.9       +7 -2      ports/games/odamex/Makefile
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 9 Martin Wilke freebsd_committer freebsd_triage 2011-02-13 07:29:51 UTC 
State Changed
From-To: open->closed

Committed. Thanks!